[release/9.0] Fixes hang in WinUI apps published to AOT#107751
Merged
jeffschwMSFT merged 8 commits intorelease/9.0from Sep 12, 2024
Merged
[release/9.0] Fixes hang in WinUI apps published to AOT#107751jeffschwMSFT merged 8 commits intorelease/9.0from
jeffschwMSFT merged 8 commits intorelease/9.0from
Conversation
…rom and adding to the nativeObjectReference list around the same time and causing removal to fail.
…d to improve performance of remove given it now takes a lock
…ads during add / remove.
github-actions
Bot
requested a review
from MichalStrehovsky
as a code owner
ghost
added
the
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
jeffschwMSFT
approved these changes
Sep 12, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. please get a code review. once ready we can merge
jkoritzinsky
approved these changes
Sep 12, 2024
This was referenced Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #104583 to release/9.0
/cc @agocke @manodasanW
Customer Impact
WinUI apps published for AOT randomly hang due to a GC exception in ComWrappers causing for them to be unable to be reliably used in production scenarios.
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Tested with WinUI Gallery published to AOT which represents a more real work app with a bunch of scenarios. This issue was exposed by a race in modifying a collection between the finalizer and another thread making it hard to catch until real apps were using it.
Risk
Low - changes scoped to ComWrappers implementation on AOT.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.