-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Improve Code Coverage for System.Security.Cryptography.Xml (66.3%) #20508
Copy link
Copy link
Closed
Labels
area-System.SecurityenhancementProduct code improvement that does NOT require public API changes/additionsProduct code improvement that does NOT require public API changes/additionsgood first issueIssue should be easy to implement, good for first-time contributorsIssue should be easy to implement, good for first-time contributorshelp wanted[up-for-grabs] Good issue for external contributors[up-for-grabs] Good issue for external contributorsin-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is mergedincrease-code-coverageTracking need to add more test and increase code coverage of a componentTracking need to add more test and increase code coverage of a component
Milestone
Metadata
Metadata
Assignees
Labels
area-System.SecurityenhancementProduct code improvement that does NOT require public API changes/additionsProduct code improvement that does NOT require public API changes/additionsgood first issueIssue should be easy to implement, good for first-time contributorsIssue should be easy to implement, good for first-time contributorshelp wanted[up-for-grabs] Good issue for external contributors[up-for-grabs] Good issue for external contributorsin-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is mergedincrease-code-coverageTracking need to add more test and increase code coverage of a componentTracking need to add more test and increase code coverage of a component
Type
Fields
Give feedbackNo fields configured for issues without a type.
Here are the main areas which need improvement:
SignedXml.CheckSignature(X509Certificate2 certificate, bool verifySignatureOnly)- currently no coverage - sample code should be sufficient for nowSystem.Security.Cryptography.Xml.XmlDecryptionTransform- https://ci.dot.net/job/dotnet_corefx/job/master/job/code_coverage_windows/Code_Coverage_Report/System.Security.Cryptography.Xml_XmlDecryptionTransform.htmSystem.Security.Cryptography.Xml.SymmetricKeyWrap- https://ci.dot.net/job/dotnet_corefx/job/master/job/code_coverage_windows/Code_Coverage_Report/System.Security.Cryptography.Xml_SymmetricKeyWrap.htmSystem.Security.Cryptography.Xml.KeyInfoClause- https://ci.dot.net/job/dotnet_corefx/job/master/job/code_coverage_windows/Code_Coverage_Report/System.Security.Cryptography.Xml_KeyInfoClause.htmSystem.Security.Cryptography.Xml.EncryptedXml- https://ci.dot.net/job/dotnet_corefx/job/master/job/code_coverage_windows/Code_Coverage_Report/System.Security.Cryptography.Xml_EncryptedXml.htm - only most common scenariosSystem.Security.Cryptography.Xml.EncryptionMethod- https://ci.dot.net/job/dotnet_corefx/job/master/job/code_coverage_windows/Code_Coverage_Report/System.Security.Cryptography.Xml_EncryptionMethod.htmSystem.Security.Cryptography.Xml.CanonicalXmlEntityReference- https://ci.dot.net/job/dotnet_corefx/job/master/job/code_coverage_windows/Code_Coverage_Report/System.Security.Cryptography.Xml_CanonicalXmlEntityReference.htm - at minimum one or two tests triggering use of this classGuidelines:
cc: @anthonylangsworth @tintoy @peterwurzinger