Skip to content

Discourage review agent from approving PRs #13512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanKrivanek merged 2 commits into from
Apr 9, 2026
Merged

Discourage review agent from approving PRs #13512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09dc90d
Prevent review agent from approving PRs - never use APPROVE event
JanKrivanek Apr 9, 2026
ae687f5
Address review comments: clarify step 3/4 exception and fix checklist…
JanKrivanek Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/agents/expert-reviewer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,8 @@ Use this to prioritize dimensions based on changed files.
- [ ] Concurrency — shared state race
```

`[x]` = LGTM or NITs only. `[ ]` = MAJOR or BLOCKING.
All `[x]` → event: **APPROVE**. Any BLOCKING → event: **REQUEST_CHANGES**. Otherwise → event: **COMMENT**.
`[x]` = LGTM or NITs only. `[ ]` = BLOCKING.
Any BLOCKING → event: **REQUEST_CHANGES**. Otherwise (including all-clear) → event: **COMMENT**.
**Never use APPROVE** — the agent must not count as a PR approval.

All inline comments from step 5 are automatically bundled into this review submission.
7 changes: 4 additions & 3 deletions .github/workflows/shared/review-shared.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@ Review pull request #${{ github.event.pull_request.number || github.event.issue.

1. Fetch the full diff for the pull request.
2. Call the `expert-reviewer` agent. Make sure to call it as subagent (`task` tool, `agent_type: "general-purpose"`, `model: "claude-opus-4.6"`). And make sure to follow the guidance on subagent calls from within the `expert-reviewer` agent. We expect 2+ levels of agents to be called.
3. Do **not** post comments yourself. The subagent will post its own comments using the available safe-output tools:
3. Do **not** post comments or reviews yourself, except for the fallback in step 4 if the subagent posts nothing. The subagent will post its own comments using the available safe-output tools:
- **Inline review comments** on specific diff lines via `create_pull_request_review_comment`
- **Design-level concerns** (not tied to a line) via `add_comment`
- **Final review verdict** (APPROVE / COMMENT / REQUEST_CHANGES) via `submit_pull_request_review`
4. If the subagent does not post anything (e.g. no issues found), post a brief approval comment.
- **Final review verdict** (COMMENT or REQUEST_CHANGES) via `submit_pull_request_review`
- **Never use APPROVE** — the agent must not count as a PR approval. Use COMMENT for clean reviews.
4. If the subagent does not post anything (e.g. no issues found), this is the only exception to step 3: post a brief fallback review using `submit_pull_request_review` with event `COMMENT` (not `APPROVE`). Do not use `add_comment` for this fallback.