Improve review aw#13510
Merged
JanKrivanek merged 5 commits intoApr 9, 2026
Merged
Conversation
Add create-pull-request-review-comment and submit-pull-request-review safe-outputs so the reviewer agent posts findings as inline diff comments (tied to specific file+line) rather than general PR comments. Update expert-reviewer Wave 3/4 instructions to use the correct tools. Also adds forks and roles support from previous commit.
Contributor
There was a problem hiding this comment.
Pull request overview
Follow-up to the initial “expert review” workflow integration, expanding it to (1) auto-trigger in more PR scenarios (incl. forks gated by repo roles) and (2) let the reviewer agent post proper inline PR review comments + a final review verdict via gh-aw safe-output tools.
Changes:
- Add role-gating (
admin,maintainer,write) to the slash-command and on-open workflows, and allow fork PRs for the on-open trigger. - Extend safe-output tooling to support inline PR review comments and submitting a final PR review (verdict).
- Update the
expert-revieweragent instructions to prefer gh-aw safe-output tools when available.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/shared/review-shared.md |
Expands safe-outputs and updates workflow prompt guidance to use inline review comments + final review submission. |
.github/workflows/review.agent.md |
Adds role gating for /review slash-command workflow. |
.github/workflows/review.agent.lock.yml |
Regenerates compiled workflow to include new safe-output tools + role gating wiring. |
.github/workflows/review-on-open.agent.md |
Allows fork PRs and adds explicit role gating for auto-run on PR open/ready. |
.github/workflows/review-on-open.agent.lock.yml |
Regenerates compiled workflow to reflect fork allowance + new safe-output tools + role gating. |
.github/agents/expert-reviewer.md |
Updates posting guidance to use gh-aw safe-output tools and adds a “tool availability” note. |
Copilot's findings
- Files reviewed: 6/6 changed files
- Comments generated: 2
pull_request from forks does not have access to repo secrets, causing the activation job to fail at COPILOT_GITHUB_TOKEN validation. Switch to pull_request_target which runs in the base repo context with full secret access. This is safe because: - The agent reads diffs via GitHub MCP tools, not by executing PR code - roles: [admin, maintainer, write] restricts to trusted contributors - Checkout is only for .github and .agents folders from the base branch Also drops ready_for_review type (not supported by gh-aw compiler for pull_request_target). Draft-to-ready PRs can use /review command. Addresses Copilot review comment about misleading roles comment.
ViktorHofer
approved these changes
Apr 9, 2026
This was referenced Jun 10, 2026
This was referenced Jun 11, 2026
Closed
Merged
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
followup of #13503
Improvements:
Note:
ready_for_reviewtrigger till 'ready_for_review' state not supported for 'pull_request_target' github/gh-aw#25436 is fixed and deployed