Skip to content

[automated] Merge branch 'vs18.6' => 'main'#13506

Merged
rainersigwald merged 4 commits into
mainfrom
merge/vs18.6-to-main
Apr 14, 2026
Merged

[automated] Merge branch 'vs18.6' => 'main'#13506
rainersigwald merged 4 commits into
mainfrom
merge/vs18.6-to-main

Conversation

@github-actions

@github-actions github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

I detected changes in the vs18.6 branch which have not been merged yet to main. I'm a robot and am configured to help you automatically keep main up to date, so I've opened this PR.

This PR merges commits made on vs18.6 by the following committers:

Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.

merge button instructions

If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.

Instructions for merging via command line

Run these commands to merge this pull request from the command line.

git fetch
git checkout vs18.6
git pull --ff-only
git checkout main
git pull --ff-only
git merge --no-ff vs18.6

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet/msbuild HEAD:merge/vs18.6-to-main
or if you are using SSH
git push git@github.com:dotnet/msbuild HEAD:merge/vs18.6-to-main

After PR checks are complete push the branch

git push

Instructions for resolving conflicts

⚠️ If there are merge conflicts, you will need to resolve them manually before merging. You can do this using GitHub or using the command line.

Instructions for updating this pull request

Contributors to this repo have permission update this pull request by pushing to the branch 'merge/vs18.6-to-main'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
The provided examples assume that the remote is named 'origin'. If you have a different remote name, please replace 'origin' with the name of your remote.

git fetch
git checkout -b merge/vs18.6-to-main origin/main
git pull https://github.com/dotnet/msbuild merge/vs18.6-to-main
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet/msbuild HEAD:merge/vs18.6-to-main
or if you are using SSH
git fetch
git checkout -b merge/vs18.6-to-main origin/main
git pull git@github.com:dotnet/msbuild merge/vs18.6-to-main
(make changes)
git commit -m "Updated PR with my changes"
git push git@github.com:dotnet/msbuild HEAD:merge/vs18.6-to-main

Contact .NET Core Engineering (dotnet/dnceng) if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.

MichalPavlik and others added 2 commits April 2, 2026 13:12
## Release 18.6 — Phase 4: Final Branding

Tracking issue: #13468

### Changes
- Add \<DotNetFinalVersionKind>release</DotNetFinalVersionKind>\ on the
\VersionPrefix\ line (creates merge conflict for forward-flow)
- Change \PreReleaseVersionLabel\ from \preview\ to \servicing\

Generated by \scripts/Stabilize-Release.ps1\.

### Next steps after merge
- Bootstrap OptProf for \�s18.6\
- Babysit VS insertion PR into VS \main\ before insiders snap (Apr 3)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fixes devdiv2860587

### Summary

Fixes the `BuildManager.ShutdownAllNodes()` API used to close MSBuild at
VS shutdown.

### Customer Impact

VS didn't clean up after itself and left `MSBuild.exe` processes idle
after shutdown.

### Regression?

Yes, worked in 18.5. 

### Testing

Manual validation of fix.

### Risk

Low. This API is used when acquiring (existing) nodes, but that codepath
always passed in enough information to avoid the bug.
@github-actions github-actions Bot requested a review from a team as a code owner April 8, 2026 13:32
@rainersigwald rainersigwald enabled auto-merge April 8, 2026 13:37
@rainersigwald rainersigwald merged commit 2a2f251 into main Apr 14, 2026
10 checks passed
@rainersigwald rainersigwald deleted the merge/vs18.6-to-main branch April 14, 2026 13:25
This was referenced Jun 10, 2026
This was referenced Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants