Add GetCanonicalForm to the AbsolutePath API#13088
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a GetFullPath() method to the AbsolutePath struct to provide an API that fully replicates Path.GetFullPath behavior, including resolving relative path segments ("." and "..") and normalizing directory separators on Windows. This enables replacing direct Path.GetFullPath calls in task code with a more controlled API.
Changes:
- Added
GetFullPath()method with optimization to avoid allocations when no normalization is needed - Added comprehensive unit tests for both Windows and Unix platforms
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Framework/PathHelpers/AbsolutePath.cs | Implements GetFullPath() with detection logic for relative segments and separator normalization needs |
| src/Framework.UnitTests/AbsolutePath_Tests.cs | Adds test cases for null paths, Windows path normalization, and Unix path normalization |
AR-May
commented
Jan 22, 2026
AR-May
force-pushed
the
update-absolute-path-api
branch
from
f1d94ca to
d9b4d89
Compare
JanProvaznik
left a comment
JanProvaznik
left a comment
Member
There was a problem hiding this comment.
should this pr also use this new method on the already migrated tasks where needed?
AR-May
changed the title
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
let me do it in separate pr for that, i would like to get this in and start using in my draft prs. |
JanProvaznik
approved these changes
Feb 6, 2026
This was referenced Jun 2, 2026
Closed
Bump Microsoft.Build from 18.4.0 to 18.6.3
SkylineCommunications/Skyline.DataMiner.CICD.Packages#159
Open
This was referenced Jun 10, 2026
Closed
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
It is quite often that
Path.GetFullPathis used in the tasks code. For enlightening we would want to replace it with our own API. The candidate wasTaskEnvironment.GetAbsolutePathfor replacing.However, they do not do the same set of actions.
TaskEnvironment.GetAbsolutePathonly absolutizes the path but does not resolve possible "." and ".." in the path or normalize path separators on Windows.For some scenarios this is critical, for some that does not matter. We should provide an option for fully copy
Path.GetFullPathbehaviorChanges Made
AbsolutePath.GetCanonicalForm()Testing
Added unit tests