[vs17.14] Merge tag v17.14.8#11861
Merged
rainersigwald merged 3 commits intodotnet:vs17.14from May 19, 2025
Merged
Conversation
DownloadFile should not rely on the remote server response headers. Unless the DestinationFileName task parameter is specified - let's just fallback to the request URI - which is as well the publicly documented behavior
We're doing a version bump so all branches have up-to-date opt-prof runs. [OptProf data](https://dev.azure.com/devdiv/_apps/hub/ms-vscs-artifact.build-tasks.drop-hub-group-explorer-hub?name=OptimizationData/DotNet-msbuild-Trusted/vs17.14/20250407.8/11350433/1) ---- #### AI description (iteration 1) #### PR Classification Version bump. #### PR Summary This pull request updates the version prefix in the project configuration to reflect a new release. - `eng/Versions.props`: Updated `<VersionPrefix>` from `17.14.5` to `17.14.6`. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
Conflicts: eng/Versions.props
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates file-download logic to derive the filename directly from the request URI, and bumps the library version to 17.14.8 with a servicing pre-release label.
- Switch
TryGetFileNameto takeUriinstead ofHttpResponseMessageand remove header-based filename extraction - Bump
<VersionPrefix>to 17.14.8 and change<PreReleaseVersionLabel>toservicinginVersions.props
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Tasks/DownloadFile.cs | Change TryGetFileName signature to use Uri and drop ContentDisposition fallback |
| eng/Versions.props | Version bump to 17.14.8 and update pre-release label to servicing |
Comments suppressed due to low confidence (1)
src/Tasks/DownloadFile.cs:324
- Removing the header-based fallback (
response.Content.Headers.ContentDisposition?.FileName) will break downloads where the server provides a filename via Content-Disposition. Consider re-introducing header inspection by passing bothUriandHttpResponseMessageor retrieving headers before switching signatures.
filename = !string.IsNullOrWhiteSpace(DestinationFileName?.ItemSpec)
YuliiaKovalova
approved these changes
May 19, 2025
rainersigwald
requested changes
May 19, 2025
Member
rainersigwald
left a comment
rainersigwald
left a comment
There was a problem hiding this comment.
I will merge via fast-forward on green.
This was referenced Jul 28, 2025
This was referenced Aug 4, 2025
This was referenced Aug 15, 2025
This was referenced Mar 24, 2026
This was referenced Apr 3, 2026
Merged
This was referenced Apr 10, 2026
This was referenced Apr 20, 2026
This was referenced Apr 28, 2026
Closed
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Context
Changes Made
Testing
Notes