Don't ngen StringTools.net35#11544
Merged
rainersigwald merged 1 commit intovs17.14from Mar 11, 2025
Merged
Conversation
This assembly shouldn't ever be loaded in the net4x context so don't spend the install time ngening it.
rainersigwald
added
the
Area: Visual Studio
Contributor
|
Hello @rainersigwald, I noticed that you’re changing an .swr file or any file under src/Package/MSBuild.VSSetup.. Please make sure to validate this change by an experimental VS insertion. This is accomplished by pushing to an exp/* branch, which requires write permissions to this repo. |
Member
Author
|
Exp insertion passed perf DDRITs: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullRequest/616357#1741610257. |
Member
Is there a way to quickly check if it improved any of the 8 regressions we care about? (I just checked one of them manually - it didn't regress further but it didn't improve it either) |
SimaTian
approved these changes
Mar 11, 2025
JanProvaznik
approved these changes
Mar 11, 2025
Member
|
do we want this in 17.14? |
Member
Author
|
@SimaTian not "quickly" that I know of, manual per-scenario-per-metric check is all I know too. |
Member
Author
Yeah probably. |
maridematte
added a commit
that referenced
this pull request
Mar 19, 2025
* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 11081403 * Update Versions.props VersionPrefix * Update Versions.props VersionPrefix * [vs17.14] Remove deprecated 4.3.* System package references & fix entries in Version.Details.xml (#11571) * Remove deprecated 4.3.* package references Both "System.Runtime" and "System.Private.Uri" are inbox in .NETCoreApp since ~2017 and don't need to be referenced explicitly anymore. They were referenced here as external dependencies brought vulnerable netstandard1.x dependencies in which were then flagged by CG. That isn't the case anymore. xunit, shouldly and other packages with their corresponding versions used in this repo don't bring netstandard1.x in anymore. Don't reference "System.Net.Http" for the same reason. It is inbox on .NET Framework, .NETCoreApp and .NET Standard. On .NET Framework a "<Reference Include="System.Net.Http" />" item is needed as it isn't part of the default referenced assemblies. Note that this change will help when starting to consume a .NET 10 SDK as those would get flagged by NuGet Prune Package Reference and NuGet Audit. * Avoid netstandard1.x dependencies * fix build * Fix entries in Version.Details.xml and make version overriding clearer (#11561) Follow-up to #11145. We were missing the entry for System.Text.Encoding.CodePages in Version.Details.xml which caused a prebuild in dotnet/sdk#47377. Also simplified the way we reference the different package versions a bit to make it clearer. Remove Microsoft.VisualStudio.SolutionPersistence from SourceBuildPrebuiltBaseline.xml, since we now properly reference it from source-build-externals --------- Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> * Don't ngen StringTools.net35 (#11544) This assembly shouldn't ever be loaded in the net4x context so don't spend the install time ngening it. * Make SolutionParser package reference private (#11603) Context The VS insertion is currently failing due to the SolutionParser version being upgraded beyond the version used by VS. Made the change so this reference is not exposed and so the insertions do not fail. --------- Co-authored-by: dotnet bot <dotnet-bot@dotnetfoundation.org> Co-authored-by: Jenny Bai <v-jennybai@microsoft.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> Co-authored-by: Rainer Sigwald <raines@microsoft.com> Co-authored-by: Mariana Dematte <magarces@microsoft.com>
This was referenced Jul 28, 2025
This was referenced Mar 24, 2026
This was referenced Apr 3, 2026
Merged
This was referenced Apr 10, 2026
This was referenced Apr 20, 2026
This was referenced Apr 28, 2026
Closed
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This assembly shouldn't ever be loaded in the net4x context so don't spend the install time ngening it.