Fix typo in Clipboard.shared.cs#35316
Merged
kubaflo merged 11 commits intodotnet:inflight/currentfrom May 6, 2026
Merged
Conversation
The credential provider plugin and Azure Artifacts feed add significant overhead locally (~10+ min builds reported by team). Use google()/mavenCentral() for local builds and only switch to the Azure Artifacts feed when TF_BUILD=True (Azure Pipelines). The init.gradle still handles Android SDK bindings Gradle targets redirection in CI via the pipeline template. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- eng/ingest-maven-deps.sh now exports TF_BUILD=True so Gradle resolves through the Azure Artifacts feed during ingestion - Use equalsIgnoreCase for TF_BUILD check to handle any casing Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…5219) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## Problem PR dotnet#35169 switched all Gradle repos to the Azure Artifacts feed unconditionally. This causes **10+ minute local Android builds** because the credential provider plugin adds significant auth overhead (MSAL token acquisition, feed latency vs direct Maven Central). Reported by team members in India experiencing builds that never complete. ## Fix Use `google()`/`mavenCentral()` for local builds and only switch to the Azure Artifacts feed when `TF_BUILD=True` (Azure Pipelines with CFSClean network isolation). ```groovy if (System.getenv('TF_BUILD') == 'True') { // Azure Artifacts feed for CI } else { // Standard Maven repos for local dev } ``` This also removes the credential provider plugin dependency for local builds since it's not needed when using standard Maven repos. The `init.gradle` still handles the Android SDK bindings Gradle targets redirection in CI via the pipeline template. ## Verified - ✅ Local build uses standard Maven repos (fast, no credential provider overhead) - ✅ CI sets `TF_BUILD=True` which activates the Azure Artifacts feed
- Remove Checkout-GhAwPr.ps1 (116 lines) — checkout not needed, agent reads PR data via MCP tools - Remove gh-aw-workflows.instructions.md (replaced by gh-aw-guide skill) - Simplify copilot-evaluate-tests.md: - Remove checkout step (agent uses MCP tools, not filesystem) - Add roles: [admin, maintain, write] (was missing) - Fix cancel-in-progress: true → false (slash_command best practice) - Update prompt to reference MCP tools instead of local files Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
<!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## Description Simplifies the evaluate-tests gh-aw workflow and removes obsolete files. ### Changes **Workflow improvements (`copilot-evaluate-tests.md`):** - Remove checkout step — agent reads PR data via MCP tools, not filesystem - Add `roles: [admin, maintain, write]` (was missing — security gap) - Fix `cancel-in-progress: true` → `false` (slash_command best practice per gh-aw guide) - Update prompt to reference MCP tools instead of local files **Removed files:** - `Checkout-GhAwPr.ps1` (116 lines) — no longer needed since workflows use MCP tools - `gh-aw-workflows.instructions.md` (290 lines) — replaced by the gh-aw-guide skill
…5106) ## Summary Add guidance to always use the `ci-analysis` skill when investigating CI failures instead of manual AzDO API queries. ## Motivation During the net11.0 stabilization work, we repeatedly made incomplete CI assessments by manually querying AzDO APIs — missing Helix work item failures, not cross-referencing known build errors, and giving incorrect all-clear signals. The `ci-analysis` skill handles all of this automatically but was not being used consistently. ## Changes ### `copilot-instructions.md` - New **Investigating CI Failures** section under CI Pipelines - Mandates `ci-analysis` skill for all CI status checks - Documents what the skill provides (Helix logs, known issue matching, cross-build aggregation) - Lists trigger phrases and anti-patterns - Documents XHarness exit-0 blind spot for `maui-pr-devicetests` with cross-check guidance - Adds escalation path to `helix-investigation` and `azdo-build-investigator` skills ## Context dotnet/runtime has no equivalent CI investigation guidance in their copilot instructions — this is MAUI-specific due to our multi-pipeline setup (maui-pr + maui-pr-uitests + maui-pr-devicetests) and Helix test infrastructure. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
<!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## Description Removes the Expert Code Review (`/review`) gh-aw workflow. Will be re-added with improvements from PR dotnet#35220. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ability (dotnet#35133) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! > **Depends on dotnet#35136** (pipeline category detection — should merge first) ## What this does Two things: ### 1. UI test category detection in PR review During the PR review workflow, Step 0.5 detects which UI test categories the PR impacts and writes the result to the AI summary comment. This gives reviewers visibility into which UI tests are relevant. **Detection** reuses the 3-tier script from dotnet#35136 (test attributes → source paths → AI reasoning). **AI summary** shows a new 🧪 UI Tests section with detected categories before the gate section. ### 2. Gate reliability fixes Multiple fixes to make the gate (`verify-tests-fail.ps1`) more deterministic: | Fix | Problem it solves | |-----|-------------------| | **Absolute path resolution** | Gate scripts not found on Linux CI agents (`Resolve-Path`, `GetFullPath`) | | **File existence check** | Instant cryptic failure when verify script is missing — now logs clear error | | **3x retry on ENV ERROR** | Emulator timeouts, ADB failures, app crashes — transient issues that pass on retry | | **Strip bad report blocks** | Old verify script produces `Passed: False` with empty counts — stripped instead of shown | | **Gate log in fallback** | When report is missing, shows last 20 lines of gate output instead of just `❌ FAILED / Platform: IOS` | ## Files | File | Changes | |------|---------| | `.github/scripts/Review-PR.ps1` | Step 0.5 category detection + all 5 gate fixes | | `.github/scripts/post-ai-summary-comment.ps1` | Add `uitests` phase to render detected categories | | `.github/pr-review/pr-preflight.md` | Step 7: AI identifies impacted UI test categories | ## Validation — PR reviewer builds (Apr 26) 10 builds against real PRs — all succeeded ✅. Category detection shown in AI summary comment. | PR | Categories Detected | Build | AI Summary | |----|-------------------|-------|------------| | dotnet#35037 (WebView theme) | `ViewBaseTests,WebView` | [13940071](https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=13940071) | [comment](dotnet#35037 (comment)) | | dotnet#35031 (Shell memory leak) | `Shell` | [13940072](https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=13940072) | [comment](dotnet#35031 (comment)) | | dotnet#35020 (XAML Hot Reload) | _(none — XAML only)_ | [13940073](https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=13940073) | ✅ Shows "No UI test categories" | | dotnet#35008 (Shell SearchHandler) | `Shell` | [13940074](https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=13940074) | ✅ | | dotnet#34997 (RadioButton gradient) | `RadioButton,ViewBaseTests` | [13940075](https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=13940075) | ✅ | | dotnet#34980 (DatePicker rotation) | `ViewBaseTests` | [13940076](https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=13940076) | ✅ | | dotnet#34974 (Picker CharacterSpacing) | `ViewBaseTests` | [13940077](https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=13940077) | ✅ | | dotnet#34923 (SwipeView threshold) | `SwipeView,ViewBaseTests` | [13940078](https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=13940078) | ✅ | | dotnet#34907 (CollectionView ScrollTo) | `CollectionView` | [13940079](https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=13940079) | ✅ | | dotnet#34845 (RefreshView binding) | `RefreshView,ViewBaseTests` | [13940080](https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=13940080) | ✅ | --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This pull request updates the following dependencies [marker]: <> (Begin:a71c12d9-5aa4-4b46-e2d6-08da0cf8cd95) ## From https://github.com/dotnet/xharness - **Subscription**: [a71c12d9-5aa4-4b46-e2d6-08da0cf8cd95](https://maestro.dot.net/subscriptions?search=a71c12d9-5aa4-4b46-e2d6-08da0cf8cd95) - **Build**: [20260429.1](https://dev.azure.com/dnceng/internal/_build/results?buildId=2963227) ([312418](https://maestro.dot.net/channel/2/github:dotnet:xharness/build/312418)) - **Date Produced**: April 29, 2026 1:57:22 PM UTC - **Commit**: [9d5a7e96236317f6312b25590e93ce6c363b62c3](dotnet/xharness@9d5a7e9) - **Branch**: [main](https://github.com/dotnet/xharness/tree/main) [DependencyUpdate]: <> (Begin) - **Dependency Updates**: - From [11.0.0-prerelease.26107.1 to 11.0.0-prerelease.26229.1][1] - Microsoft.DotNet.XHarness.CLI - Microsoft.DotNet.XHarness.TestRunners.Common - Microsoft.DotNet.XHarness.TestRunners.Xunit [1]: dotnet/xharness@bfbac23...9d5a7e9 [DependencyUpdate]: <> (End) [marker]: <> (End:a71c12d9-5aa4-4b46-e2d6-08da0cf8cd95) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35316Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35316" |
github-actions Bot
pushed a commit
that referenced
this pull request
May 6, 2026
### Description of Change Fixed a small typo in Clipboard.shared.cs. Nothing exciting, really. ### Issues Fixed Given that this is an extremely small typo fix only, I thought I'd just go ahead and file a PR. ---------
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixed a small typo in Clipboard.shared.cs. Nothing exciting, really.
Issues Fixed
Given that this is an extremely small typo fix only, I thought I'd just go ahead and file a PR.