Conversation
There was a problem hiding this comment.
Pull Request Overview
Reverts the temporary trimming analyzer workaround in the netstandard2.0 build targets so that trimming warnings are once again enabled.
- Removed the conditional
<PropertyGroup>that disabled the trim analyzer and suppressed related warnings. - Restored default trimming analyzer behavior for non-AOT, non-full-trim, non-explicit-suppression scenarios.
Comments suppressed due to low confidence (1)
|
@rolfbjarne seems still lots of warnings on the sample apps , device tests etc.. is there anything else other than ignore the warnings ? |
|
@rmarinho do you have a binlog with some of the warnings? no relevant test seems to show up as failing here: https://dev.azure.com/xamarin/public/_build/results?buildId=146082&view=ms.vss-test-web.build-test-results-tab&runId=4521190&resultId=100038&paneView=debug |
5de370b to
b05c187
Compare
2a5652f to
537cd6e
Compare
|
/rebase |
537cd6e to
1515955
Compare
|
/rebase |
1515955 to
61863a7
Compare
|
/rebase |
kubaflo
left a comment
There was a problem hiding this comment.
Can you please resolve conflicts?
|
|
Description of Change
When moving to net10.0 we disable some trimming warnings for iOS, will try enable them again.