Update README.md#2
Closed
diverdan92 wants to merge 5 commits intodotnet:masterfrom
Closed
Conversation
Closed
hartez
added a commit
that referenced
this pull request
Apr 21, 2022
mattleibow
pushed a commit
that referenced
this pull request
Jun 18, 2022
jonathanpeppers
added a commit
that referenced
this pull request
Sep 14, 2022
/Users/builder/azdo/_work/3/s/bin/dotnet/packs/Microsoft.MacCatalyst.Sdk/15.4.1153-rc.2/targets/Xamarin.Shared.Sdk.targets(371,3): error : Unable to merge the file 'Contents/Resources/Assets.car', it's different between the input app bundles. [/Users/builder/azdo/_work/3/s/src/Controls/samples/Controls.Sample.Sandbox/Maui.Controls.Sample.Sandbox.csproj::TargetFramework=net7.0-maccatalyst] /Users/builder/azdo/_work/3/s/bin/dotnet/packs/Microsoft.MacCatalyst.Sdk/15.4.1153-rc.2/targets/Xamarin.Shared.Sdk.targets(371,3): error : App bundle file #1: /Users/builder/azdo/_work/3/s/src/Controls/samples/Controls.Sample.Sandbox/bin/Release/net7.0-maccatalyst/maccatalyst-x64/Maui.Controls.Sample.Sandbox.app/Contents/Resources/Assets.car [/Users/builder/azdo/_work/3/s/src/Controls/samples/Controls.Sample.Sandbox/Maui.Controls.Sample.Sandbox.csproj::TargetFramework=net7.0-maccatalyst] /Users/builder/azdo/_work/3/s/bin/dotnet/packs/Microsoft.MacCatalyst.Sdk/15.4.1153-rc.2/targets/Xamarin.Shared.Sdk.targets(371,3): error : App bundle file #2: /Users/builder/azdo/_work/3/s/src/Controls/samples/Controls.Sample.Sandbox/bin/Release/net7.0-maccatalyst/maccatalyst-arm64/Maui.Controls.Sample.Sandbox.app/Contents/Resources/Assets.car [/Users/builder/azdo/_work/3/s/src/Controls/samples/Controls.Sample.Sandbox/Maui.Controls.Sample.Sandbox.csproj::TargetFramework=net7.0-maccatalyst]
kubaflo
pushed a commit
that referenced
this pull request
May 7, 2026
All three Round 5 reviewers (claude-opus-4.7-xhigh, claude-sonnet-4.6, gpt-5.5) converged on a cascading bug introduced by Round 4's fixes interacting: 1. Round 4 fix #2 intentionally creates a 0-byte reviewer-findings.diff for the documented Blocked-with-no-diff path. But Get-Content -Raw on a 0-byte file returns $null, not "". So Step 7.5's drift detection becomes '"" -ne $null' → True → false-positive drift on every Blocked attempt. This re-introduces the 'always evaluates truthy' failure mode Round 4 was supposed to eliminate (just shifted from array-vs-scalar to string-vs-null). 2. The new SHA256 hash sentinel throws on legitimate byte-identical refreshes (e.g., '[]' → '[]' after a small compile fix that introduces no new violations, or single-finding → same-single-finding). The case is common, not 'extremely rare' as the error message claimed. Compounds with #1: the false-positive drift forces a re-walk that correctly writes '[]' again, then the hash check throws → unhandled exception → Step 9 worktree restore skipped → next attempt corrupted. Fixes: - Coalesce $null to "" via '?? '''' on the Get-Content -Raw call. Empirically verified: [string]$null does NOT coerce to '' in pwsh 7.5.4 (stays null), but '... ?? '''' does work. - Drop the SHA256 hash sentinel entirely. Step 6 has no equivalent programmatic 'did you walk the rules' check; it relies on procedural enforcement (the numbered markdown sub-steps and the example-invocation chain). Round 4 fix #3 already moved Step 7.5 to the same enforcement model. Replaced the throw with a callout explaining the trade-off. All 5 scenarios validated empirically (pwsh 7.5.4): - Empty diff (Blocked path): diffChanged=False (no false positive) - Non-empty diff unchanged: diffChanged=False - Diff changed during Step 7: diffChanged=True - Clean → clean refresh: validates, no throw - Invalid JSON: throws as expected Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.