Invalid document breaks compilation, shows wrong output

[sarink]

When working in a monorepo and using the following standard configuration:

schema: api/src/resolvers/**/*.ts

generates:
  api/src/api-types.ts:
    plugins:
      - typescript
      - typescript-resolvers

  web/src/web-types.ts:
    config:
      documents: web/src/**/*.tsx
    plugins:
      - typescript
      - typescript-operations

If a valid but breaking change is made to an api resolver, the entire compilation process will error when trying to generate the web-types, and the new api-types will never get created.

This is a confusing workflow for a backend developer, since the output shows:

  ✔ Parse configuration                                                                                                                                                                                                                                      
  ❯ Generate outputs
    ✔ Generate api/src/api-types.ts   <-- This is a lie
    ❯ Generate web/src/web-types.ts
      ✔ Load GraphQL schemas
      ✔ Load GraphQL documents
      ✖ Generate
        →     at web/src/pages/Home.tsx:3:5

I believe the tool should output whatever it can, regardless of other errors it encounters (that is, do what the output says it does). Is this expected behavior?

I'm not completely sure, but might this have something to do with using Promise.all on this line? Instead, Promise.allSettled would ensure to not throw on the first error

[ardatan]

Thank you for reporting the issue you had but we need you to follow our issue template in order to help you better;
Especially we need a minimal and clear reproduction to debug the issue on Github, Stackblitz or CodeSandbox

[sarink]

@ardatan you can just make the document.graphql file invalid in your sandbox (add asdf somewhere) and see that because of that error, no files will be generated (which makes sense, given that the code uses Promise.all).

Shouldn't the files that can be generated (ie, ones that do not rely on or use document.graphql, like the generation of the schema) still output successfully? Or is this intended behavior?

[sarink]

@ardatan if you really need a sample repo, here it is: https://codesandbox.io/s/elastic-cerf-xrwo4d you can see that because of the error in documents.graphql that the file schema.json will never be generated

[sarink]

Bump: Any update on this? Or workaround suggestion? It is a daily problem in our monorepo, any breaking change or error to a frontend query or api resolver completely blocks compilation of the other until you fix it

[eddeee888]

This will be fixed in the next major version as we enable noSilentErrors: true by default: #10496