fix issue #114#117
Open
JaiRaj22 wants to merge 1 commit intodonnemartin:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix inconsistent error handling in clean_date_time_zone
Moved all parsing logic (string slicing + strptime) inside the try block so malformed input is always caught
Added an except (ValueError, IndexError) clause that re-raises as a descriptive ValueError, making the failure mode explicit and caller-friendly
Removed the dead date_time = None / time_zone_parsed = None initialisations that existed only to support the now-removed implicit None return
Updated the docstring to accurately reflect the contract: returns a 3-tuple on success, raises ValueError on failure