Rephrase settings file rename as historical fact#24580
Open
lacatoire wants to merge 1 commit intodocker:mainfrom
Open
Rephrase settings file rename as historical fact#24580lacatoire wants to merge 1 commit intodocker:mainfrom
lacatoire wants to merge 1 commit intodocker:mainfrom
Conversation
Replace "settings.json for Docker Desktop versions 4.34 and earlier" with a factual note about when the rename happened, avoiding time-relative language that becomes stale. Fixes docker#24546
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The documentation uses time-relative language ("for Docker Desktop versions 4.34 and earlier") when mentioning the old
settings.jsonfile name, which becomes increasingly stale over time.This rephrases it as a historical fact: the file was renamed from
settings.jsontosettings-store.jsonin Docker Desktop 4.35.Fixes #24546