TUI - Improve notifications#2931
Merged
Merged
Conversation
rumpl
previously approved these changes
May 29, 2026
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟡 NEEDS ATTENTION
Two medium-severity issues found in the new notification interaction code.
Summary of changes reviewed: Mouse-hover-aware auto-hide suppression, click-to-copy clipboard integration, close-button glyph overlay, and border hint text injection — all in the TUI notification component.
krissetto
force-pushed
the
improved-notification-component
branch
from
1fe12a6 to
b00c5a5
Compare
aheritier
added
area/tui
- don't auto remove them is mouse is hovering - clicking the notification will copy its contents - use a gliph for the x to close, and make it red when hovered - show action hint text in the top left of the notification border Signed-off-by: Christopher Petito <chrisjpetito@gmail.com>
krissetto
force-pushed
the
improved-notification-component
branch
from
b00c5a5 to
a694221
Compare
dgageot
approved these changes
May 29, 2026
aheritier
added a commit
that referenced
this pull request
May 29, 2026
This was referenced May 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc improvements to the TUI notifications:
xto close, and make it red when hoveredScreenshots: