Fix issue 925 (wheel rotation calculation)#945
Open
tomo0613 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#925
explanation (by Claude):
The Bug
In
src/control/ray_cast_vehicle_controller.rs, the wheel rotation update uses afwd(forward) vector computed independently from the chassis rotation:But the friction impulse system in
update_friction()computes forward as:These two methods produce vectors that can point in opposite directions depending on the axle axis convention. For example, with
index_forward_axis = 2(Z forward) and a wheel axle along-X:forward_ws[i]=Y × (-X)=-Zfwd=+Z← exact opposite!The result:
delta_rotationhas the wrong sign, making the wheel appear to spin backward (and it cancels out to ~0). When steering is applied, the axle rotates, which partially corrupts/corrects the mismatch — which is exactly why rotation only appears when steering.