Creating SourceFile

[SDelgado-21]

Implementation: https://github.com/diffplug/selfie-python-wip/blob/main/jvm/selfie-lib/src/commonMain/kotlin/com/diffplug/selfie/guts/SourceFile.kt

Tests: https://github.com/diffplug/selfie-python-wip/blob/main/jvm/selfie-lib/src/commonTest/kotlin/com/diffplug/selfie/guts/SourceFileToBeTest.kt

[nedtwigg]

• Language enum -> port, only value is python
• EscapeLeadingWhitespace enum -> port, only value is never
• ignore removeSelfieOnceComments
• The thing we want is fun parseToBeLike(lineOneIndexed: Int): ToBeLiteral {
• Key point: SourceFileToBeTest

[nedtwigg]

Your choice if this PR supports multiline strings or not.

[nedtwigg]

Good progress!

[nedtwigg]

Good progress! Some nitpick comments, looks like you'll need to at least mock-out LiteralValue so that the tests can run.

[nedtwigg]

This PR isn't about correctly implementing LiteralValue / LiteralFormat, but having a simple temporary implementation of them might make it easier. At the very least, it will be important that their type signatures are correct. See the PEP 695 docs.

• selfie-python-wip/jvm/selfie-lib/src/commonMain/kotlin/com/diffplug/selfie/guts/Literals.kt

  Line 45 in 2aededc

  class LiteralValue<T : Any>(val expected: T?, val actual: T, val format: LiteralFormat<T>)

  • T : Any means that the T can't be nullable, you can ignore the Any as far as Python goes
  • T? in Kotlin is equivalent to T | None in Python

• selfie-python-wip/jvm/selfie-lib/src/commonMain/kotlin/com/diffplug/selfie/guts/Literals.kt

  Line 47 in 2aededc

  abstract class LiteralFormat<T : Any> {

  • Note that LiteralFormat is generic, but its subclasses are not because they specify the generic parameter. I haven't seen this in Python, but I'd be very surprised if it's unsupported. If you have problems with it, let me know and I will pull your branch and help tinker.

  • selfie-python-wip/jvm/selfie-lib/src/commonMain/kotlin/com/diffplug/selfie/guts/Literals.kt

    Line 81 in 2aededc

    internal object LiteralInt : LiteralFormat<Int>() {

  • selfie-python-wip/jvm/selfie-lib/src/commonMain/kotlin/com/diffplug/selfie/guts/Literals.kt

    Line 117 in 2aededc

    internal object LiteralString : LiteralFormat<String>() {

[nedtwigg]

Excellent progress! This was a hard one, and you got the hardest parts working!

[nedtwigg]

Excellent work! I think this is ready merge. @SDelgado-21 if you agree click "Ready for review" and then "Merge pull request".

I would set the commit message to "Ported SourceFile (#20)" but it's not crucial.