Skip to content

compiler: Intify StencilDimension attributes#2755

Merged
mloubout merged 1 commit intomainfrom
intify-stencildim
Oct 6, 2025
Merged

compiler: Intify StencilDimension attributes#2755
mloubout merged 1 commit intomainfrom
intify-stencildim

Conversation

@FabioLuporini
Copy link
Copy Markdown
Contributor

Test in PRO as you need to work hard with substitutions to trigger the following error inside sympy

/venv/lib/python3.10/site-packages/sympy/core/basic.py:413: in compare
    c = l.compare(r)
/venv/lib/python3.10/site-packages/sympy/core/basic.py:419: in compare
    c = (l > r) - (l < r)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = True, other = False

    def _noop(self, other=None):
>       raise TypeError('BooleanAtom not allowed in this context.')
E       TypeError: BooleanAtom not allowed in this context.

This is nothing relevant -- just a stupid exception when sympy needs to establish if A should precede B (or the other way round) in the arguments list of a given expression (in this case, of IndexDerivatives)

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.05%. Comparing base (a04b3af) to head (bc70ce4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2755   +/-   ##
=======================================
  Coverage   83.04%   83.05%           
=======================================
  Files         248      248           
  Lines       50438    50438           
  Branches     4437     4437           
=======================================
+ Hits        41886    41890    +4     
+ Misses       7792     7789    -3     
+ Partials      760      759    -1     
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.76% <100.00%> (+0.01%) ⬆️
pytest-gpu-nvc-nvidiaX 69.29% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mloubout mloubout merged commit 20c433f into main Oct 6, 2025
36 checks passed
@mloubout mloubout deleted the intify-stencildim branch October 6, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants