compiler: Expose Bundle's properties correctly#2487
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2487 +/- ##
=======================================
Coverage 87.28% 87.28%
=======================================
Files 238 238
Lines 45325 45330 +5
Branches 4027 4027
=======================================
+ Hits 39561 39566 +5
Misses 5083 5083
Partials 681 681 ☔ View full report in Codecov by Sentry. |
| '_offset_domain', '_offset_halo', '_offset_owned', '_dist_dimensions', | ||
| '_C_get_field', 'grid', 'symbolic_shape']: | ||
| '_C_get_field', 'grid', 'symbolic_shape', | ||
| *AbstractFunction.__properties__): |
There was a problem hiding this comment.
Nitpick: ('_mem_internal_eager', '_mem_internal_lazy', ...) + AbstractFunction.__properties__ might be tidier imo
There was a problem hiding this comment.
a + b creates two tuples a, b then a new third one to merge them while current one only creates one directly.
| if len({i.__padding_dtype__ for i in components}) != 1: | ||
| raise ValueError("Components must have the same padding dtype") | ||
| if len({i.properties for i in components}) != 1: | ||
| raise ValueError("Components must have the same properties") |
There was a problem hiding this comment.
looks more like "counting" rather than "comparing", should you say, the same number of properties?
There was a problem hiding this comment.
It's not counting properties it's check the set length one, i.e all properties are the same
4 participants
No description provided.