dsl: Add ArgProvider inheritance to AbstractSymbol#2482
Merged
FabioLuporini merged 2 commits intomasterfrom Nov 13, 2024
Merged
dsl: Add ArgProvider inheritance to AbstractSymbol#2482FabioLuporini merged 2 commits intomasterfrom
FabioLuporini merged 2 commits intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2482 +/- ##
==========================================
- Coverage 87.26% 87.26% -0.01%
==========================================
Files 238 238
Lines 45278 45271 -7
Branches 4022 4022
==========================================
- Hits 39512 39505 -7
Misses 5085 5085
Partials 681 681 ☔ View full report in Codecov by Sentry. |
mloubout
reviewed
Nov 13, 2024
Contributor
mloubout
left a comment
mloubout
left a comment
There was a problem hiding this comment.
What issue is this for?
devito/types/basic.py
Outdated
|
|
||
|
|
||
| class Scalar(Symbol, ArgProvider): | ||
| class Scalar(Symbol): |
Contributor
There was a problem hiding this comment.
Well that was intentional
- Scalar carry data
- Symbol don't carry data
So the second one is not an arg provider as it does not have values
Contributor
Author
There was a problem hiding this comment.
It's to remove the extraneous no-op methods in Thickness. Maybe DataSymbol should get ArgProvider instead then?
mloubout
approved these changes
Nov 13, 2024
georgebisbas
approved these changes
Nov 13, 2024
FabioLuporini
approved these changes
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a default no-op
_arg_values,_arg_checketc to any subclasses ofAbstractSymbol.