Update contributing guide#421
Merged
michael-valdron merged 4 commits intoJun 12, 2024
Merged
Conversation
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Member
Author
N/A |
2 tasks
thepetk
reviewed
Jun 11, 2024
Contributor
thepetk
left a comment
thepetk
left a comment
There was a problem hiding this comment.
Left some minor comments :)
Co-authored-by: Theofanis Petkos <thepetk@gmail.com> Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
michael-valdron
force-pushed
the
chore/update-contributing
branch
from
abf0b45 to
08bef51
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Summarize the changes. Are any stacks or samples added or updated?
Updates contributing guide and supporting documents with up to date information and layout.
Additionally, adds missing
DCOfile into repository.Which issue(s) this PR fixes:
Link to github issue(s)
fixes devfile/api#1347
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: