Skip to content

feat: update controller runtime to v0.9.5#567

Merged
sleshchenko merged 5 commits into
mainfrom
controller-runtime-update
Sep 2, 2021
Merged

feat: update controller runtime to v0.9.5#567
sleshchenko merged 5 commits into
mainfrom
controller-runtime-update

Conversation

@JPinkney
Copy link
Copy Markdown
Contributor

@JPinkney JPinkney commented Aug 30, 2021

What does this PR do?

This PR is the rebased version of #540. I tried to avoid overriding that one just in case something messed up.

What issues does this PR fix or reference?

#516

Is it tested? How?

Not yet so I'm leaving at WIP for now

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v7-devworkspaces-operator-e2e, v7-devworkspace-happy-path to trigger)
    • v7-devworkspaces-operator-e2e: DevWorkspace e2e test
    • v7-devworkspace-happy-path: DevWorkspace e2e test

@amisevsk @JPinkney
Update codebase to reflect later k8s APIs
8555854 
Prep code for supporting k8s 1.21:

* Add context.Context parameter to Reconcile() functions [1]
* Add RBAC get/create/update coordination.k8s.io/v1 Leases (replacing a
  configmap for leader election locks) [2]
* Adapt event handler code to reflect simplification [3]
* Adapt to apimachinery/pkg/runtime Log deprecation (replaced with
  pkg/client Log) [4]
* client.Object is preferred in favor of runtime.Object (v0.7.0 release) [5]
* Use admission/v1 instead of v1beta1 for webhook requests [6]

[1] - kubernetes-sigs/controller-runtime#1054
[2] - kubernetes-sigs/controller-runtime#1144
[3] - kubernetes-sigs/controller-runtime#1119
[4] - kubernetes-sigs/controller-runtime#1105
[5] - kubernetes-sigs/controller-runtime#898
      kubernetes-sigs/controller-runtime#1118
[6] - kubernetes-sigs/controller-runtime#1284

kubernetes-sigs/controller-runtime@a32b29d
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@amisevsk @JPinkney
Update dependencies to match controller-runtime v0.9.5
d4677a9 
Update sigs.k8s.io/controller-runtime to version v0.9.5, and match other
dependencies to those used by controller-runtime, notably:

* k8s.io/api, k8s.io/apimachinery, k8s.io/client-go updated to v0.21.3
* Go version should be upgraded to 1.16 but isn't since there isn't a Go
  1.16 UBI image we can use as builder.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@amisevsk @JPinkney
Regenerate deployment files and OLM bundle
62f1cb6 
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Aug 30, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot requested review from amisevsk and sleshchenko August 30, 2021 17:27
@JPinkney JPinkney changed the title Controller runtime update to v0.9.5 feat: Controller runtime update to v0.9.5 Aug 30, 2021
@JPinkney
Update devworkspace configmap handling to work with the new controlle…
458c1cd 
…r-runtime

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
@JPinkney JPinkney marked this pull request as ready for review August 31, 2021 22:03
@JPinkney JPinkney changed the title feat: Controller runtime update to v0.9.5 feat: update controller runtime to v0.9.5 Aug 31, 2021
@JPinkney
Copy link
Copy Markdown
Contributor Author

JPinkney commented Aug 31, 2021

/test v7-devworkspaces-operator-e2e

2 similar comments
@JPinkney
Copy link
Copy Markdown
Contributor Author

JPinkney commented Aug 31, 2021

/test v7-devworkspaces-operator-e2e

@JPinkney
Copy link
Copy Markdown
Contributor Author

JPinkney commented Sep 1, 2021

/test v7-devworkspaces-operator-e2e

@sleshchenko
Copy link
Copy Markdown
Member

sleshchenko commented Sep 1, 2021

e2e test fails with

github.com/devfile/devworkspace-operator/controllers/controller/devworkspacerouting/solvers imports
sigs.k8s.io/controller-runtime/pkg/builder tested by
sigs.k8s.io/controller-runtime/pkg/builder.test imports
sigs.k8s.io/controller-runtime/pkg/internal/testing/addr imports
io/fs: malformed module path "io/fs": missing dot in first path element

@sleshchenko
Copy link
Copy Markdown
Member

sleshchenko commented Sep 1, 2021

I expect openshift/release#21509 to fix the e2e tests

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Sep 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JPinkney, sleshchenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JPinkney,sleshchenko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the lgtm label Sep 1, 2021
@sleshchenko
Copy link
Copy Markdown
Member

sleshchenko commented Sep 1, 2021

/test v8-devworkspaces-operator-e2e

@sleshchenko
Copy link
Copy Markdown
Member

sleshchenko commented Sep 1, 2021

e2e test still fails with

github.com/devfile/devworkspace-operator/controllers/controller/devworkspacerouting/solvers imports
sigs.k8s.io/controller-runtime/pkg/builder tested by
sigs.k8s.io/controller-runtime/pkg/builder.test imports
sigs.k8s.io/controller-runtime/pkg/internal/testing/addr imports
io/fs: package io/fs is not in GOROOT (/usr/local/go/src/io/fs)

@JPinkney
Call go env GOPROXY before go mod tidy and vendor
d7387b8 
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
@openshift-ci openshift-ci Bot removed the lgtm label Sep 1, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Sep 1, 2021

New changes are detected. LGTM label has been removed.

@JPinkney
Copy link
Copy Markdown
Contributor Author

JPinkney commented Sep 1, 2021

/test v8-devworkspaces-operator-e2e

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Sep 1, 2021 •
edited
Loading

@JPinkney: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/v7-devworkspaces-operator-e2e 458c1cd link /test v7-devworkspaces-operator-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JPinkney
Copy link
Copy Markdown
Contributor Author

JPinkney commented Sep 1, 2021

/test v8-devworkspaces-operator-e2e

@sleshchenko sleshchenko merged commit 9a0c330 into main Sep 2, 2021
@sleshchenko sleshchenko deleted the controller-runtime-update branch September 2, 2021 07:36
@sleshchenko sleshchenko mentioned this pull request Sep 2, 2021
Closed
3 tasks
@AndrienkoAleksandr AndrienkoAleksandr mentioned this pull request Sep 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amisevsk amisevsk Awaiting requested review from amisevsk

1 more reviewer

@sleshchenko sleshchenko sleshchenko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sleshchenko sleshchenko

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JPinkney @sleshchenko @amisevsk