Store trait sequences as tuples, not lists#620
Merged
Conversation
kylebarron
changed the title
roger120981
pushed a commit
to roger120981/lonboard
that referenced
this pull request
Jul 14, 2025
Ref developmentseed#592 (comment) This should be easier to follow for users. Mutating a list trait doesn't propagate any updates to the frontend. Rather, you must set a new object. Storing tuple traits instead of list traits means that it's impossible for the user to accidentally not sync those updates to the frontend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #592 (comment)
This should be easier to follow for users. Mutating a list trait doesn't propagate any updates to the frontend. Rather, you must set a new object. Storing tuple traits instead of list traits means that it's impossible for the user to accidentally not sync those updates to the frontend.