ci: bump actions/upload-artifact from 4 to 6#1
Closed
dependabot[bot] wants to merge 2 commits into
Closed
Conversation
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 6. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v6) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
Contributor
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
Bot
deleted the
dependabot/github_actions/actions/upload-artifact-6
branch
decriptor
added a commit
that referenced
this pull request
Apr 19, 2026
Five review comments on #30 identified that the CombinedTag and FlacTag facades had semantics inconsistent with the Tag abstraction and with the rest of the IMediaFile implementations. All five are addressed: 1. CombinedTag.Render was a silent no-op returning empty bytes. A CombinedTag is a view, not a serializable block -- rendering it should surface misuse. Now throws NotSupportedException with a message pointing callers to the owning file or a specific underlying tag. 2. CombinedTag.Clear was a silent no-op. "Clear the tag" must actually zero out the metadata, not succeed while leaving the values intact. Now clears every non-null underlying tag. 3. CombinedTag setters were silent no-ops. Code in this repo and documented examples assume `file.Tag.Title = "x"` mutates the file, so silently dropping writes broke a load-bearing contract. Setters now write through to every non-null underlying tag, which also keeps ID3v2 + ID3v1 consistent on save. 4. FlacFile.Tag and Mp3File.Tag always returned a non-null facade even on files with no metadata. Other IMediaFile implementations (Dsf, Dff, Musepack, WavPack, MonkeysAudio, Ogg*, Asf, Mp4, Aiff) return null when the tag block is absent. Both now match that convention: null when the file has neither an underlying tag nor pictures. 5. FlacTag.Render/Clear had the same issue as #1-2. Render now throws NotSupportedException (a FlacTag spans multiple metadata blocks -- render the FlacFile); Clear now wipes the VorbisComment fields (including embedded METADATA_BLOCK_PICTURE entries via VorbisComment.Clear) and removes native PICTURE blocks. Test updates: * CombinedTagTests: replaced the three no-op characterization tests with their mirror-image positive tests (setters write through, Render throws, Clear clears every member). * FlacTagTests: replaced the combined "Render+Clear are no-ops" test with separate positive tests for Render throwing and Clear clearing. Added Tag_AbsentMetadata_ReturnsNull to lock in the nullability contract. Updated tests that started from a CreateMinimal() FLAC (Tag == null now) to seed with a VorbisComment first. * Mp3FileTests: added Tag_NoTagsPresent_ReturnsNull for the nullability contract and Tag_Setter_WritesThroughToBothIdTags to verify the write-through behavior keeps v2 and v1 in sync. All 3807 functional tests pass on net8.0 and net10.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/upload-artifact from 4 to 6.
Release notes
Sourced from actions/upload-artifact's releases.
... (truncated)
Commits
b7c566aMerge pull request #745 from actions/upload-artifact-v6-releasee516bc8docs: correct description of Node.js 24 support in READMEddc45eddocs: update README to correct action name for Node.js 24 support615b319chore: release v6.0.0 for Node.js 24 support017748bMerge pull request #744 from actions/fix-storage-blob38d4c79chore: rebuild dist7d27270chore: add missing license cache files for@actions/core,@actions/io, and mi...5f643d3chore: update license files for@actions/artifact@5.0.1 dependencies1df1684chore: update package-lock.json with@actions/artifact@5.0.1b5b1a91fix: update@actions/artifactto ^5.0.0 for Node.js 24 punycode fixDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)