Fix unittests#769
Merged
decalage2 merged 2 commits intodecalage2:masterfrom Nov 27, 2022
Merged
Conversation
This was referenced Jun 17, 2022
Before using log_helper in olevba logged a "finalization message", which is no longer required. Had forgotten to update unittests.
Arg "keepends" is a non-keyword-arg in python 2.7
christian-intra2net
force-pushed
the
fix-unittests
branch
from
92f4c53 to
560b903
Compare
decalage2
approved these changes
Nov 27, 2022
decalage2
approved these changes
Nov 27, 2022
Contributor
Author
|
Thanks, this makes for a good start into the week :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix unittests and problem for olevba in python 2.7