Added functionality to read/return GroupName text.#532
Merged
decalage2 merged 19 commits intodecalage2:masterfrom Jan 31, 2020
kirk-sayre-work:merge2master
Merged
Added functionality to read/return GroupName text.#532decalage2 merged 19 commits intodecalage2:masterfrom kirk-sayre-work:merge2master
decalage2 merged 19 commits intodecalage2:masterfrom
kirk-sayre-work:merge2master
Conversation
…ntrol. Save the Caption text returned from consume_LabelControl in dict returned from extract_OleFormVariables.
…eing parsed has a tag or controltiptext.
This may help prevent unread data being left in the OLE stream when the GroupName text size is > 0.
decalage2
approved these changes
Jan 31, 2020
Owner
|
Thanks for fixing the issues with PR #319 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added functionality for the following:
consume_MorphDataControl() now reads and returns the value of the GroupText field. The data for non-zero size GroupText fields was previously not being consumed so this may fix some errors on some documents. The GroupText value is now returned as one of the data elements for an embedded object. (Test Document Hash: fffa19ec1db3453a942c5090816e758585f11ecc1fc7dc942340be7cce6f1ad8)
Added a --no-xlm option to skip extracting XLM macros (the default is still to extract XLM macros). I added this option since for some reason some documents take a very long time to process when XLM macro extraction is attempted.
Tightened up the logic for detecting MHT files. Some malicious VBScript contain variables named 'mime', 'version', and 'multipart' which triggered a false MHT classification with the old check.