Skip to content

Remove Excessive Abstraction#29

Merged
hayesZach merged 8 commits intomasterfrom
fix/remove-abstraction
Feb 3, 2026
Merged

Remove Excessive Abstraction#29
hayesZach merged 8 commits intomasterfrom
fix/remove-abstraction

Conversation

@hayesZach
Copy link
Copy Markdown
Collaborator

@hayesZach hayesZach commented Feb 2, 2026

Note

Medium Risk
Refactors database initialization and lifecycle management, removing the prior singleton-style repositories; mistakes here could affect migrations/seeding, connection handling, and shutdown behavior.

Overview
Simplifies the repository layer by removing the PrivateRepository/PublicRepository abstractions and making repository.Factory the single entry point for repo access and cleanup (now embeds io.Closer).

factory.NewFactory now owns opening both SQLite DBs, running PRAGMA setup, migrations, seeding (including admin API key), and public index creation, and Server is updated to construct/close this factory directly. Private/public packages are reduced to exported MigrateModels/Seed*/CreateIndexes helpers, and test factories are updated to satisfy the new Close() requirement.

Written by Cursor Bugbot for commit c47f76b. This will update automatically on new commits. Configure here.

@hayesZach hayesZach self-assigned this Feb 2, 2026
@hayesZach hayesZach added the Enhancement New feature or request label Feb 2, 2026
@hayesZach hayesZach marked this pull request as ready for review February 2, 2026 23:12
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@hayesZach hayesZach requested a review from Step7750 February 3, 2026 18:28
@hayesZach hayesZach merged commit a3a7c94 into master Feb 3, 2026
2 checks passed
@hayesZach hayesZach deleted the fix/remove-abstraction branch February 3, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants