fix: extract Bedrock tool call arguments from input field#4950
Open
themavik wants to merge 1 commit intocrewAIInc:mainfrom
Open
fix: extract Bedrock tool call arguments from input field#4950themavik wants to merge 1 commit intocrewAIInc:mainfrom
themavik wants to merge 1 commit intocrewAIInc:mainfrom
Conversation
…4748) Root cause: func_info.get("arguments", "{}") returns the default "{}" (truthy string) when the key is absent, preventing the or-branch from checking tool_call["input"] where Bedrock places arguments. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4748.
Root cause: In
crew_agent_executor.py,func_info.get("arguments", "{}") or tool_call.get("input", {})always evaluates to"{}"(a truthy string) when theargumentskey is absent, so theorbranch that checkstool_call["input"]never runs. AWS Bedrock places tool call arguments in theinputfield, notarguments.Fix: Changed to
func_info.get("arguments") or tool_call.get("input") or {}— matching the already-correct pattern inagent_utils.pyline 1224.Changes
lib/crewai/src/crewai/agents/crew_agent_executor.py: Removed default"{}"fromget("arguments")so falsyNonefalls through to theinputfield check.Testing
agent_utils.pyargumentskey) continue to workMade with Cursor