-
Notifications
You must be signed in to change notification settings - Fork 24
talm template --talos-version v1.12 does not discover VLAN interfaces from running node #143
Copy link
Copy link
Closed
Labels
area/chartIssues or PRs related to charts/ (Chart.yaml, helpers, templates)Issues or PRs related to charts/ (Chart.yaml, helpers, templates)area/networkingIssues or PRs related to networking (interfaces, VIP, routes)Issues or PRs related to networking (interfaces, VIP, routes)kind/bugCategorizes issue or PR as related to a bugCategorizes issue or PR as related to a bugpriority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next releaseMust be staffed and worked on either currently, or very soon, ideally in time for the next releasetriage/acceptedIndicates an issue is ready to be actively worked onIndicates an issue is ready to be actively worked on
Metadata
Metadata
Assignees
Labels
area/chartIssues or PRs related to charts/ (Chart.yaml, helpers, templates)Issues or PRs related to charts/ (Chart.yaml, helpers, templates)area/networkingIssues or PRs related to networking (interfaces, VIP, routes)Issues or PRs related to networking (interfaces, VIP, routes)kind/bugCategorizes issue or PR as related to a bugCategorizes issue or PR as related to a bugpriority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next releaseMust be staffed and worked on either currently, or very soon, ideally in time for the next releasetriage/acceptedIndicates an issue is ready to be actively worked onIndicates an issue is ready to be actively worked on
Type
Fields
Give feedbackNo fields configured for issues without a type.
Description
When running
talm templateagainst a node that has a VLAN interface configured (e.g.,enp0s31f6.4000viamachine.network.interfaces[].vlans), the generated v1.12 multidoc config only includes aLinkConfigfor the physical parent interface. The VLAN interface is silently omitted.As a result:
Layer2VIPConfigis generated withlink: enp0s31f6(physical/public) instead oflink: enp0s31f6.4000(VLAN) — placing the VIP on the wrong interfaceSteps to Reproduce
talosVersion: "v1.12"inChart.yamltalm template -t templates/controlplane.yaml -n <node-ip> -e <node-ip>Observed Output
The VLAN interface (
enp0s31f6.4000,192.168.100.2/24) is completely absent.Expected Behavior
The template should also generate VLAN configuration, either as a separate VLAN document (if such a kind exists in v1.12) or at minimum annotate the discovered interfaces comment to include VLANs, so the user knows they need to add it manually.
Layer2VIPConfigshould referenceenp0s31f6.4000when the VIP is configured on a VLAN interface.Workaround
Manually add VLAN config via legacy format in the first document and fix the VIP link:
Environment