Make both flow output identical#1191
Merged
Merged
Conversation
pyramation
reviewed
May 18, 2026
| case 'timestamp': return 'Datetime'; | ||
| default: return 'String'; // safe fallback | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
this switch — can we document where this may live in other codebases, either our codegen or upstream in graphile ? feels like this could be not DRY
pyramation
reviewed
May 18, 2026
| else if (unit.startsWith('hour')) result.hours = num; | ||
| else if (unit.startsWith('minute')) result.minutes = num; | ||
| else if (unit.startsWith('second')) result.seconds = num; | ||
| } |
Contributor
There was a problem hiding this comment.
also a bit brittle here — this could be somewhere else too, like the pgsql-parser and we can abstract this to a utils
pyramation
reviewed
May 18, 2026
| sign_in_function text, | ||
| sign_up_function text, | ||
| sign_out_function text | ||
| ); |
Contributor
There was a problem hiding this comment.
a bit duplicative, I think we have a seed for this
pyramation
reviewed
May 18, 2026
| ['timestamptz', 'Datetime', 'timestamptz'], | ||
| ['timestamp', 'Datetime', 'timestamptz'], | ||
| ['float4', 'Float', 'int'], | ||
| ['float8', 'Float', 'int'], |
Contributor
There was a problem hiding this comment.
another mapping, not DRY
pyramation
reviewed
May 18, 2026
| case 'Datetime': | ||
| return 'timestamptz'; | ||
| default: | ||
| return 'text'; // safe fallback — matches mapPgTypeToFieldType's default |
Contributor
There was a problem hiding this comment.
and ... another, not DRY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/constructive-io/constructive-planning/issues/863