feat: add Factory Droids support to codegraph install#697
Open
lukeaus wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a new installer target for Factory Droids so codegraph install can detect/configure MCP for the Droid CLI alongside existing agents.
Changes:
- Introduces a new
factorytarget that writes MCP config to~/.factory/mcp.json(global) or./.factory/mcp.json(local). - Registers the new target in the targets registry and updates installer messaging/hints.
- Adds unit tests and documents the new support in the changelog.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/installer/targets/types.ts | Extends TargetId union with factory. |
| src/installer/targets/registry.ts | Registers the new factoryTarget in ALL_TARGETS. |
| src/installer/targets/factory.ts | Implements Factory Droids target install/uninstall/detect/write logic. |
| src/installer/index.ts | Updates installer/uninstaller user-facing hints to include ~/.factory and ./.factory. |
| tests/installer-targets.test.ts | Adds coverage for Factory Droids install/uninstall behaviors. |
| CHANGELOG.md | Documents new Factory Droids support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #696.
This PR adds support for Factory Droids as a new agent target for the CLI installer.
Changes
src/installer/targets/factory.tsrepresenting Factory Droids.factorytoTargetIdtype insrc/installer/targets/types.ts.factorytarget insrc/installer/targets/registry.ts.src/installer/index.ts.CHANGELOG.mdwith Factory Droids entry under Unreleased.__tests__/installer-targets.test.ts.