🤖 fix: release settled /btw transcript holds#3345
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 789e01b476
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Keep /btw side-question scroll ownership temporary by releasing settled holds once geometry shows the branch can align at the top of the transcript viewport. Preserve the hold only while the answer is streaming or while start alignment is still bottom-clamped, so the side Q&A cannot become permanent bottom clutter.\n\n---\n\n_Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `.88`_\n\n<!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=7.88 -->
ammar-agent
force-pushed
the
transcript-qa-rc44
branch
from
789e01b to
be0eb33
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Fixes
/btwside-question scroll holds so the side Q&A can no longer remain stuck to the bottom of the transcript as permanent visual clutter.Background
/btwintentionally hands scroll ownership from bottom-lock to the side branch when main-agent output continues below the aside. The previous hold kept re-aligning through the answer lifecycle, but did not distinguish a real start-aligned branch from a browser bottom-clamp caused by insufficient content below it.Implementation
scrollIntoView({ block: "start" })is still bottom-clamped using transcript/target geometry.Validation
bun test src/browser/components/ChatPane/sideQuestionScrollHold.test.tsbun test src/browser/utils/messages/StreamingMessageAggregator.sideQuestion.test.ts src/browser/stores/WorkspaceStore.test.ts --test-name-pattern "/btw|side-question|Side question|side answer"bun run typecheckmake fmt-checkmake lintmake static-checkRisks
Low-to-moderate. The change touches transcript scroll ownership, but it is limited to
/btwside-question hold release logic and covered by targeted unit tests for streaming, settled, fallback-row, and geometry cases.Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:$7.88