Conversation
- Remove tracked Java .class files in spring-boot-postgres/aspire/ - Remove tracked Angular .angular/cache/ in dotnet-angular-cosmos/frontend/ - Remove tracked .codegen-hash in Aspire .modules/ scaffolding - Add .gitignore section covering Python venvs, Java build, frontend caches, Aspire runtime artifacts, macOS/IDE junk - Delete untracked temp/build cruft from OTel validation runs Note: samples/vite-react-api/ and samples/ts-starter/ untouched (active work). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Append summary of untracked build artifacts, disk cleanup, and .gitignore polyglot patterns. Document patterns for future runs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Follow-up to a7e37f2: stage the on-disk deletions of the sample-local nuget package cache that was accidentally tracked. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Follow-up to a7e37f2: convert unanchored patterns to **/ globs so they match anywhere in samples/. Add vite.config.{d.ts,js} when source is vite.config.ts. Also delete already-untracked build artifacts. - **/.modules/.codegen-hash now matches Aspire codegen files in any sample - **/vite.config.d.ts and **/vite.config.js catch Vite compilation output - All Python, Java, Go, .NET, and Node virtualenvs now properly matched - Deleted 6 .codegen-hash files + vite.config.js build artifacts Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ifacts) Record insights from deep cleanup pass fixing unanchored .gitignore patterns. Key learnings: glob anchoring critical for monorepo, Vite compile artifacts need manual detection, regenerating files must never be tracked. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sister commit to 05446da. The .codegen-hash files in flask, spring-boot, svelte-go, ts-starter, and vite-react-api were tracked from before the **/ anchor fix; deleting them on disk without 'git add -u' left them as unstaged deletions. Stage and remove for good — pattern in .gitignore covers them going forward. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Added OpenTelemetry dependencies to package.json for tracing and instrumentation. - Created instrumentation.ts to set up tracing, including document load, fetch, and user interaction instrumentation. - Updated main.tsx to import the new instrumentation module. - Defined VITE_ environment variables in vite-env.d.ts for OpenTelemetry configuration. - Modified vite.config.ts to rewrite OTLP endpoint for browser compatibility and expose necessary environment variables to client code. - Added TypeScript configuration for apphost in tsconfig.apphost.json. - Updated presentation slides to reflect changes in the Aspire architecture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the styling for fit titles (titles using Marp's feature) in both the dark and light custom Aspire themes. The main goal is to add side margins to
h1elements containing fit SVGs, preventing them from running edge-to-edge and improving readability.Fit title styling improvements:
custom-aspire-light.cssandcustom-aspire-dark.cssso thatsection h1elements containing a fit SVG (svg[data-marp-fitting="svg"]) now have side margins (margin-inline: 4%), with increased margins (margin-inline: 6%) for special section types such ascover,lead,purple,gradient, andinvert. [1] [2]