fix: support has/missing conditions on config headers and fix glob exclude patterns in routing#134
Closed
erayack wants to merge 1 commit intocloudflare:mainfrom
Closed
Conversation
…clude patterns in routing
Collaborator
|
Hey @erayack, thanks for this PR! The core
Going to close this PR since the individual pieces are covered, but really appreciate the contribution. Each of those PRs credits you as the commit author. |
Contributor
Author
|
Sounds great! Thanks for splitting these up and for the credit on the separate PRs. Glad I could help! @southpolesteve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes config
headers()matcher parity with redirects/rewrites by addinghas/missingcondition evaluation, and hardens behavior to fail closed when conditional header rules are evaluated without request context.What changed
has/missingsupport to config header matching in shared matcher and dev server path.NextHeadertyping to includehasandmissing.has/missingconditions.matchHeaders, including no-context fail-closed behavior.next/dynamic) by replacing ambiguous text locator with an exact heading-role locator.Why
Previously,
headers()rules only matchedsourceand ignored request-context conditions, causing behavior mismatch with redirects/rewrites and Next.js compatibility gaps.Validation