feat(localizations): Update is-IS, nb-NO, fi-FI, hr-HR, hu-HU with missing translations#8224
feat(localizations): Update is-IS, nb-NO, fi-FI, hr-HR, hu-HU with missing translations#8224bjaben wants to merge 4 commits intoclerk:mainfrom
Conversation
…ssing translations
|
@bjaben is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 945c91f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughA changeset file 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/localizations/src/hu-HU.ts (1)
221-221:⚠️ Potential issue | 🟠 MajorUse the numeric formatter for
dates.numeric.Line 221 uses
timeString('hu-HU')fordates.numeric, so this entry will render only the time instead of a numeric date. That breaks the Hungariandates.numericvariant anywhere it is used.Suggested fix
- numeric: "{{ date | timeString('hu-HU') }}", + numeric: "{{ date | numeric('hu-HU') }}",As per coding guidelines, "Check for formatting issues, such as missing placeholders, incorrect variable usage, or syntax errors."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/localizations/src/hu-HU.ts` at line 221, The dates.numeric entry currently uses timeString('hu-HU') which outputs only the time; update the dates.numeric formatter to use the numeric date formatter instead of timeString (replace the timeString('hu-HU') usage in the dates.numeric entry with the appropriate numeric formatter for Hungarian, e.g., the project’s numeric/dateNumeric formatter for 'hu-HU') so that dates.numeric renders a full numeric date rather than only the time.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@packages/localizations/src/hu-HU.ts`:
- Line 221: The dates.numeric entry currently uses timeString('hu-HU') which
outputs only the time; update the dates.numeric formatter to use the numeric
date formatter instead of timeString (replace the timeString('hu-HU') usage in
the dates.numeric entry with the appropriate numeric formatter for Hungarian,
e.g., the project’s numeric/dateNumeric formatter for 'hu-HU') so that
dates.numeric renders a full numeric date rather than only the time.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: 8c700ab2-bf6a-4872-9b40-fde18dca2e45
📒 Files selected for processing (6)
.changeset/update-icelandic-localization.mdpackages/localizations/src/fi-FI.tspackages/localizations/src/hr-HR.tspackages/localizations/src/hu-HU.tspackages/localizations/src/is-IS.tspackages/localizations/src/nb-NO.ts
Ephem
left a comment
There was a problem hiding this comment.
Thanks a lot for this contribution, this is super valuable! 🙏
Based on a few agent reviews and my own reading of the Norwegian translations (I don't master the language at all, but as a Swedish speaker I can read it), this is looking great.
Quick background question: How many of these languages do you master or have familiarity with? I get if this is mostly machine translated, which is more than fine, but how many of these languages would you say you can meaningfully judge the quality of yourself?
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Our team covers IS, NO and FI pretty well but less so HR and HU. |
Description
Update five community-maintained localizations with complete translations for all previously missing sections. This brings these languages up to parity with en-US.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit