fix(vitest): support multi browser instance setups#332
Open
AriPerkkio wants to merge 1 commit intomainfrom
Open
fix(vitest): support multi browser instance setups#332AriPerkkio wants to merge 1 commit intomainfrom
AriPerkkio wants to merge 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: a625dc7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
AriPerkkio
changed the title
AriPerkkio
force-pushed
the
ari/fix-multi-browser-instance-setup
branch
from
7ef1be4 to
ec81fd0
Compare
AriPerkkio
commented
May 5, 2026
Comment on lines
+53
to
+54
| // browser.name is instances[].browser, not instances[].name: https://github.com/vitest-dev/vitest/blob/d22b029ae056b9515033d75c1249e9db26612770/packages/vitest/src/node/projects/resolveProjects.ts#L307 | ||
| if (!browser.enabled || browser.name !== 'chromium') { |
Member
Author
There was a problem hiding this comment.
AriPerkkio
force-pushed
the
ari/fix-multi-browser-instance-setup
branch
2 times, most recently
from
67c1d65 to
0533fac
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
==========================================
- Coverage 91.00% 90.66% -0.35%
==========================================
Files 22 23 +1
Lines 634 643 +9
Branches 118 121 +3
==========================================
+ Hits 577 583 +6
- Misses 54 57 +3
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AriPerkkio
force-pushed
the
ari/fix-multi-browser-instance-setup
branch
from
0533fac to
47a4609
Compare
AriPerkkio
requested review from
JReinhold,
kasperpeulen,
ndelangen and
vanessayuenn
AriPerkkio
force-pushed
the
ari/fix-multi-browser-instance-setup
branch
from
47a4609 to
b47ebcc
Compare
AriPerkkio
force-pushed
the
ari/fix-multi-browser-instance-setup
branch
from
b47ebcc to
a625dc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #295
What Changed
Support cases where user defines multiple browser instances:
How to test