fix(vitest): resolve root from root config#326
Merged
AriPerkkio merged 1 commit intomainfrom Apr 30, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 6faf415 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
==========================================
+ Coverage 91.47% 92.01% +0.54%
==========================================
Files 22 22
Lines 598 601 +3
Branches 109 110 +1
==========================================
+ Hits 547 553 +6
+ Misses 48 45 -3
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AriPerkkio
force-pushed
the
ari/fix-resolve-root-from-root-config
branch
2 times, most recently
from
7ac80ab to
6e0fb33
Compare
AriPerkkio
force-pushed
the
ari/fix-resolve-root-from-root-config
branch
from
6e0fb33 to
6faf415
Compare
JReinhold
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: Related to #295
What Changed
Results should be written in root of the whole Vitest process, not in Vitest
project's root. All test reporters should output to main root.Also when outputting files to the same directory, we need to make sure multiple projects don't overwrite each other's results. So now we'll be namespacing results with project name, when there are multiple projects configured.
How to test
There's test case that fails without this fix.
Noticed this while testing against https://github.com/skeletonlabs/skeleton.