fix: resolve viewport dimensions from Vitest's iframe#314
Merged
AriPerkkio merged 2 commits intomainfrom Apr 23, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: aa11a02 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Apr 16, 2026
AriPerkkio
force-pushed
the
ari/fix-viewport-from-iframe
branch
from
567ea6b to
30bcd37
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
==========================================
+ Coverage 91.62% 91.63% +0.01%
==========================================
Files 22 22
Lines 609 610 +1
Branches 103 102 -1
==========================================
+ Hits 558 559 +1
Misses 48 48
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AriPerkkio
force-pushed
the
ari/fix-viewport-from-iframe
branch
from
530f4ee to
0b092e4
Compare
AriPerkkio
force-pushed
the
ari/fix-viewport-from-iframe
branch
from
0b092e4 to
3b19458
Compare
AriPerkkio
force-pushed
the
ari/fix-viewport-from-iframe
branch
from
0d22d6d to
3b19458
Compare
AriPerkkio
force-pushed
the
ari/fix-viewport-from-iframe
branch
from
3b19458 to
aa11a02
Compare
JReinhold
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: Related to #295
What Changed
While testing in downstream projects, noticed that viewports were completely off. Vitests' built-in
page.viewport()only adjust the UI's iframe's scaling and dimensions - not the whole viewport.How to test
Added two commits that show the fix before-and-after. The test case can be used to reproduce the bug before fix is applied.