Skip to content

Experiment with sb & dependencies upgrade#282

Merged
AriPerkkio merged 70 commits intomainfrom
norbert/experiment-sb-compat
Apr 1, 2026
Merged

Experiment with sb & dependencies upgrade#282
AriPerkkio merged 70 commits intomainfrom
norbert/experiment-sb-compat

Conversation

@ndelangen
Copy link
Copy Markdown
Member

@ndelangen ndelangen commented Mar 3, 2026

I'm attempting to reduce the incompatibility of this package when combined within a repository that already contains storybook.

What Changed

This PR telescopes on PR where this work has been done:

  • Upgrade eslint to latest (needed for SB10
  • Modify eslint config files to adhere to latest version
  • Formatting changes due to eslint upgrades
  • Upgrade typescript to latest (needed for SB10)
  • Change tsconfig to use moduleResolution:bundler (needed for SB10)
  • Removed source map generation
  • Disabled minification
  • Use node 22 in GitHub actions (SB10 does not support Node18)
  • upgrade cypress (to support moduleResolution:bundler)
  • replace jest with vitest

This PR itself, now only contains the following changes:

  • Upgrade storybook to latest
  • Remove addon-essentials ( no longer exists in SB10)
  • Change local addon using '.' to direct references to manager and preview files in main.* files.
  • regenerate lockfile
  • make the main, preview and manager files ESM

How to test

🦋 @chromatic-com/cypress@0.12.0-e90627a-20260401073204
🦋 @chromatic-com/playwright@0.13.0-e90627a-20260401073204

…patible with old version of eslint-import-plugin
…sing newline in package.json, and refine outputFile function parameter type in filePaths.ts. Adjust writeTestResult to cast response body as any for compatibility.
@ndelangen ndelangen changed the title Norbert/experiment sb compat Experiment with sb & dependencies upgrade Mar 3, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.75%. Comparing base (ea271c9) to head (e90627a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #282   +/-   ##
=======================================
  Coverage   95.75%   95.75%           
=======================================
  Files          14       14           
  Lines         400      400           
  Branches       68       68           
=======================================
  Hits          383      383           
  Misses         16       16           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ndelangen ndelangen self-assigned this Mar 3, 2026
Comment thread packages/playwright/vitest.config.ts Outdated
Comment thread packages/playwright/src/makeTest.test.ts Outdated
Comment thread packages/shared/src/archive-storybook/viewports.test.ts Outdated
Comment thread packages/shared/src/write-archive/index.test.ts Outdated
Comment thread vitest.config.ts Outdated
Comment thread vitest.config.ts Outdated
Comment thread vitest.config.ts Outdated
@skitterm skitterm requested a review from tevanoff March 3, 2026 16:26
Copy link
Copy Markdown
Member

@skitterm skitterm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndelangen thanks for taking this on!

It looks like there are a lot of cascading changes in this PR (to upgrade SB to 10, we need eslint upgraded; also we need Cypress upgraded to 15 for the same reason, Node needs to be upgraded, etc).

If this PR is opened just to be able to publish canary versions (and will later be split up before it's out of draft state), no worries.

If this PR is intended to be merged in its current format, I'd prefer to split this up into a few separate PRs (Cypress to 15, eslint upgraded, then SB to 10) to keep things manageable and avoid regressions.

Comment thread package.json Outdated
Comment thread packages/playwright/package.json Outdated
Comment thread packages/playwright/tsup.config.ts
Comment thread test-server/fixtures/dynamic-content.html
@ndelangen ndelangen requested a review from skitterm March 9, 2026 13:36
Comment thread packages/cypress/src/storybook-config/main.ts Outdated
Comment thread packages/playwright/src/storybook-config/main.ts Outdated
Comment thread packages/playwright/src/storybook-config/main.ts Outdated
Copy link
Copy Markdown
Member

@skitterm skitterm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndelangen thanks for this! See my couple comments below, but I don't need to re-review before you merge this.

Comment thread packages/shared/storybook-config/preview.ts
Comment thread .changeset/hot-needles-tap.md Outdated
Comment thread packages/cypress/package.json Outdated
Comment thread packages/shared/src/utils/filePaths.test.ts Outdated
Base automatically changed from norbert/upgrade-eslint to main March 30, 2026 08:37
@AriPerkkio AriPerkkio self-assigned this Mar 30, 2026
Comment thread packages/shared/src/archive-storybook/index.ts Outdated
This was linked to issues Mar 31, 2026
@AriPerkkio AriPerkkio marked this pull request as ready for review April 1, 2026 07:01
@AriPerkkio AriPerkkio merged commit bf9e686 into main Apr 1, 2026
8 of 9 checks passed
@AriPerkkio AriPerkkio deleted the norbert/experiment-sb-compat branch April 1, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Storybook v8 security issue Support for Storybook v9

5 participants