Experiment with sb & dependencies upgrade#282
Conversation
…patible with old version of eslint-import-plugin
…sing newline in package.json, and refine outputFile function parameter type in filePaths.ts. Adjust writeTestResult to cast response body as any for compatibility.
…r upgraded Storybook dependencies
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
=======================================
Coverage 95.75% 95.75%
=======================================
Files 14 14
Lines 400 400
Branches 68 68
=======================================
Hits 383 383
Misses 16 16
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… release, test-base, test-cypress, and test-playwright.
…ure the same version is used in CI and local dev
skitterm
left a comment
There was a problem hiding this comment.
@ndelangen thanks for taking this on!
It looks like there are a lot of cascading changes in this PR (to upgrade SB to 10, we need eslint upgraded; also we need Cypress upgraded to 15 for the same reason, Node needs to be upgraded, etc).
If this PR is opened just to be able to publish canary versions (and will later be split up before it's out of draft state), no worries.
If this PR is intended to be merged in its current format, I'd prefer to split this up into a few separate PRs (Cypress to 15, eslint upgraded, then SB to 10) to keep things manageable and avoid regressions.
…ation for Cypress and Playwright
skitterm
left a comment
There was a problem hiding this comment.
@ndelangen thanks for this! See my couple comments below, but I don't need to re-review before you merge this.
…or Cypress and Playwright
I'm attempting to reduce the incompatibility of this package when combined within a repository that already contains storybook.
What Changed
This PR telescopes on PR where this work has been done:
jestwithvitestThis PR itself, now only contains the following changes:
'.'to direct references tomanagerandpreviewfiles inmain.*files.main,previewandmanagerfiles ESMHow to test