ENT-13075: Error if user tries to call bundle inside custom promise#34
Merged
olehermanse merged 1 commit intocfengine:mainfrom Mar 30, 2026
Merged
ENT-13075: Error if user tries to call bundle inside custom promise#34olehermanse merged 1 commit intocfengine:mainfrom
olehermanse merged 1 commit intocfengine:mainfrom
Conversation
SimonThalvorsen
force-pushed
the
ENT-13075
branch
from
65c1f55 to
3a048a4
Compare
olehermanse
reviewed
Mar 30, 2026
olehermanse
reviewed
Mar 30, 2026
Ticket: ENT-13075 Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
SimonThalvorsen
force-pushed
the
ENT-13075
branch
from
3a048a4 to
29f3610
Compare
olehermanse
reviewed
Mar 30, 2026
olehermanse
reviewed
Mar 30, 2026
olehermanse
approved these changes
Mar 30, 2026
Member
olehermanse
left a comment
olehermanse
left a comment
There was a problem hiding this comment.
Looks good in general. I added a few suggestions for naming and comments, but nothing serious. You could improve those in a follow-up PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: ENT-13075