Fix DeprecationWarning: asyncio.iscoroutinefunction on Python 3.14#1075
Open
MertYksl03 wants to merge 1 commit intocanbula:masterfrom
Open
Fix DeprecationWarning: asyncio.iscoroutinefunction on Python 3.14#1075MertYksl03 wants to merge 1 commit intocanbula:masterfrom
MertYksl03 wants to merge 1 commit intocanbula:masterfrom
Conversation
… inspect.iscoroutinefunction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes
While running the tests locally on Python 3.14, I noticed a DeprecationWarning regarding
asyncio.iscoroutinefunction. Since this is slated for removal in 3.16, I’ve updated thetest_awaitablemethod to useinspect.iscoroutinefunctionto ensure future compatibility. We use Python 3.12 i know but this is a good practice to avoid deprecation warnings and ensure the code remains functional in future Python versions.Warning Message
Expected Behavior
No deprecation warnings. asyncio.iscoroutinefunction should be replaced with inspect.iscoroutinefunction.
inspect.iscoroutinefunction is available since Python 3.5, so this is fully backward-compatible.
Does this look okay to merge?
Checklist