fix(browser-operator): add missing win/meta/super key mappings#1868
Open
octo-patch wants to merge 1 commit intobytedance:mainfrom
Open
fix(browser-operator): add missing win/meta/super key mappings#1868octo-patch wants to merge 1 commit intobytedance:mainfrom
octo-patch wants to merge 1 commit intobytedance:mainfrom
Conversation
The 'win' key (Windows Meta key) was not included in KEY_MAPPINGS, causing an 'Unsupported key: win' error when UI-TARS tried to execute hotkeys involving the Windows key. Also adds 'meta' and 'super' as aliases for cross-platform compatibility. Fixes bytedance#1843
✅ Deploy Preview for tarko canceled.
|
✅ Deploy Preview for agent-tars-docs canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1843
Problem
When UI-TARS tries to execute a hotkey involving the Windows key (
win), it throws:This is because
win(the Windows Meta key) was not present inKEY_MAPPINGSinkey-map.ts. Any hotkey combination usingwin(e.g.,win+dfor Show Desktop,win+rfor Run dialog) would fail with this error.Solution
Added the following key aliases to
KEY_MAPPINGS:win→'Meta'(Windows key on Windows)meta→'Meta'(explicit Meta key reference)super→'Meta'(Linux/Unix convention for the Super/Windows key)These all map to Puppeteer's
'Meta'KeyInput, which represents the platform meta key (Windows key on Windows, Command key on macOS).Testing
The fix can be verified by triggering a hotkey action that uses the
winkey — the errorUnsupported key: winwill no longer be thrown, and the key will be correctly mapped toMetain the browser keyboard event.