fix(agent): send final streaming message with isComplete flag after stream ends#1831
Open
Br1an67 wants to merge 1 commit intobytedance:mainfrom
Open
fix(agent): send final streaming message with isComplete flag after stream ends#1831Br1an67 wants to merge 1 commit intobytedance:mainfrom
Br1an67 wants to merge 1 commit intobytedance:mainfrom
Conversation
When the LLM stream finishes, the finish_reason typically arrives in a separate content-less chunk. Since we only send assistant_streaming_message for chunks with content, the last streaming message always had isComplete: false, causing the Web UI to appear stuck in streaming state. Send a final assistant_streaming_message with isComplete: true after the stream loop completes when content was streamed and finishReason is set. Closes bytedance#833
✅ Deploy Preview for tarko ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for agent-tars-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
14 tasks
Contributor
Author
|
Hi — just a gentle bump on this. Happy to make any changes if needed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #833
The OpenAI streaming API sends
finishReasonin a separate content-less chunk after the last content chunk. The streaming handler only setisComplete: truewhen both content andfinishReasonwere present in the same chunk, which never happened. As a result, noassistant_streaming_messageevent withisComplete: truewas ever emitted.Changes:
hasStreamedContentflagassistant_streaming_messagewithisComplete: truewhen content was streamed andfinishReasonis setThis ensures the UI receives a proper stream completion signal.
Checklist