migrate langchain into braintrust pkg without auto instrumentation#150
Conversation
Abhijeet Prasad (AbhiPrasad)
left a comment
There was a problem hiding this comment.
Can we use git mv on the code in https://github.com/braintrustdata/braintrust-sdk-python/tree/main/integrations/langchain-py/src/braintrust_langchain? That way we maintain git history for the moved files.
We can do the same thing we did in adk-py, and just leave a deprecation warning + move the files https://github.com/braintrustdata/braintrust-sdk-python/blob/main/integrations/adk-py/src/braintrust_adk/__init__.py
| self, response: list[Document], *, run_id: UUID, parent_run_id: UUID | None = None, **kwargs: Any | ||
| ) -> Any: | ||
| pass | ||
| __all__ = ["BraintrustCallbackHandler", "BraintrustTracer", "set_global_handler", "clear_global_handler"] |
There was a problem hiding this comment.
Removing BraintrustTracer is a breaking change. We can do this, but I would prefer not to do it. Instead let's leave a note at the top of the file that braintrust.integrations.langchain is the new import, and update the _logger.warning in BraintrustTracer to have the new deprecation.
a7b390e to
b3f9f03
Compare
Fix #27
Migrates braintrust-langchain to the main braintrust python pkg.
Migration Guide:
braintrust-langchaintobraintrustBefore
After
What to update
Coming soon
Auto-instrumentation support for the langchain integration