Shared Ansible Dependencies#1270
Merged
TheTechromancer merged 33 commits intomodule-hooksfrom Apr 26, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## module-hooks #1270 +/- ##
=============================================
- Coverage 92% 91% -0%
=============================================
Files 323 325 +2
Lines 21493 21611 +118
=============================================
+ Hits 19562 19660 +98
- Misses 1931 1951 +20 ☔ View full report in Codecov by Sentry. |
Implement Radix Tree
liquidsec
approved these changes
Apr 26, 2024
stryker2k2
approved these changes
Apr 26, 2024
Contributor
stryker2k2
left a comment
There was a problem hiding this comment.
Author walked me through this Pull Request. All questions were answered. Code looks good. Test look legit.
Faster Regexes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds shared ansible dependencies, a feature that carves out a dedicated place for common third-party ansible dependencies such as
ffuf,massdns,chromium, etc:This is designed to prevent multiple modules from having to define the same ansible dependency.
Modules can leverage these dependencies by including them in their

deps_commonattribute: