fix: improve check for already exited processes on windows#464
Open
ceisele-r wants to merge 1 commit intobahmutov:masterfrom
Open
fix: improve check for already exited processes on windows#464ceisele-r wants to merge 1 commit intobahmutov:masterfrom
ceisele-r wants to merge 1 commit intobahmutov:masterfrom
Conversation
Contributor
ceisele-r
commented
May 7, 2026
ceisele-r
commented
- On Windows, already exited processes are not (always) reported as ESRCH, therefore match the error message to check if the process already exited
Collaborator
|
Thanks @ceisele-r for the contribution! Is there any way to add this to the test suite? I'm just wondering how to judge whether the code is right or not. |
ceisele-r
force-pushed
the
improve-already-exited-check
branch
2 times, most recently
from
84ea513 to
5d7d57c
Compare
* On Windows, already exited processes are not (always) reported as ESRCH, therefore match the error message to check if the process already exited
ceisele-r
force-pushed
the
improve-already-exited-check
branch
from
5d7d57c to
ca7077d
Compare
Contributor
Author
|
Hi @MikeMcC399 , I've added a test that simulates this and tests the behavior. |
Collaborator
|
Thanks for adding the tests! I'll approve this now and leave it open for comments for a few days. Based on past experience though I'm not really expecting any other reviews, but in the spirit of "open source" I'd like to give other users the chance to comment (including the owner of this repo by the way). |
MikeMcC399
approved these changes
May 7, 2026
Collaborator
MikeMcC399
left a comment
MikeMcC399
left a comment
There was a problem hiding this comment.
Thank you very much for the enhancement!
Contributor
Author
|
Thank you @MikeMcC399 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.