Skip to content

fix(verification): Verify cache identifier#1578

Merged
RitvikKapila merged 2 commits intorkapila/shared-cache-beaconsfrom
rkapila/shared-cache-beacons-identifier
Jan 22, 2025
Merged

fix(verification): Verify cache identifier#1578
RitvikKapila merged 2 commits intorkapila/shared-cache-beaconsfrom
rkapila/shared-cache-beacons-identifier

Conversation

@RitvikKapila
Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@RitvikKapila RitvikKapila requested a review from a team as a code owner January 17, 2025 21:06
Copy link
Copy Markdown
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown

@RitvikKapila and @seebees, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@RitvikKapila RitvikKapila merged commit 5e4a115 into rkapila/shared-cache-beacons Jan 22, 2025
@RitvikKapila RitvikKapila deleted the rkapila/shared-cache-beacons-identifier branch January 22, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants