chore: Add examples to examine contents of query error list by ajewellamz · Pull Request #1251 · aws/aws-database-encryption-sdk-dynamodb

ajewellamz · 2024-08-06T23:37:13Z

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

robin-aws

Just commenting on the error handling.

robin-aws · 2024-08-07T17:34:18Z

+      System.err.println(e);
+      System.err.println(e.getMessage());
+      System.err.println(e.getCause());
+      System.err.println(((CollectionOfErrors) e.getCause()).list());


It's interesting to me that the CollectionOfErrors ends up as an indirect cause in Java but thrown directly in C#, do you know why?

Not a clue.

robin-aws · 2024-08-07T17:35:38Z

+        {
+            Console.Error.WriteLine("Encryptor Error : " + e.Message);
+        }
+        catch (AWS.Cryptography.DbEncryptionSDK.DynamoDb.Transforms.CollectionOfErrors e)


It's unfortunate that we end up with multiple declarations of CollectionOfErrors in different namespaces, but again that's out of scope for this PR. Might look a bit cleaner to add a using for this though.

lucasmcdonald3

The CollectionOfErrors behavior is unfortunate, but the examples are good.
Tracking underlying behavior in https://sim.amazon.com/issues/CrypTool-5349

## [3.6.1](v3.6.0...v3.6.1) (2024-08-12) ### Fixes * allow multi-tenant queries with allow_plaintext ([#1240](#1240)) ([1487d7e](1487d7e)) * **TestVectors:** define StartUpObject in csproj ([#1231](#1231)) ([2f97bf3](2f97bf3)) ### Maintenance * Add examples to examine contents of query error list ([#1251](#1251)) ([b5705ee](b5705ee)) * **CI:** add smithy diff checker GHA ([#1226](#1226)) ([86406f5](86406f5)) * **deps:** bump actions/setup-dotnet from 3 to 4 in /.github/workflows ([#1191](#1191)) ([c3b736e](c3b736e)) * **deps:** bump aws-actions/configure-aws-credentials ([#1190](#1190)) ([becbd0a](becbd0a)) * **deps:** bump com.amazonaws:aws-java-sdk-dynamodb ([#1230](#1230)) ([3aa25d0](3aa25d0)) * **deps:** bump dafny-lang/setup-dafny-action in /.github/workflows ([#1200](#1200)) ([5284f0b](5284f0b)) * **deps:** bump software.amazon.awssdk:bom ([#1227](#1227)) ([abd1727](abd1727)) * **deps:** bump software.amazon.awssdk:bom ([#1229](#1229)) ([bf3e1c3](bf3e1c3)) * **deps:** bump software.amazon.awssdk:core ([#1228](#1228)) ([9c67729](9c67729)) * do not add beacons when FORCE_PLAINTEXT_WRITE is used. ([#1232](#1232)) ([23c8a18](23c8a18)) * include bad item keys in query errors ([#1244](#1244)) ([07bba8b](07bba8b)) * update version to snapshot ([#1225](#1225)) ([c817b5b](c817b5b))

## [3.6.1](v3.6.0...v3.6.1) (2024-08-12) ### Fixes * allow multi-tenant queries with allow_plaintext ([#1240](#1240)) ([1487d7e](1487d7e)) * **TestVectors:** define StartUpObject in csproj ([#1231](#1231)) ([2f97bf3](2f97bf3)) ### Maintenance * Add examples to examine contents of query error list ([#1251](#1251)) ([b5705ee](b5705ee)) * **CI:** add smithy diff checker GHA ([#1226](#1226)) ([86406f5](86406f5)) * **deps:** bump actions/setup-dotnet from 3 to 4 in /.github/workflows ([#1191](#1191)) ([c3b736e](c3b736e)) * **deps:** bump aws-actions/configure-aws-credentials ([#1190](#1190)) ([becbd0a](becbd0a)) * **deps:** bump com.amazonaws:aws-java-sdk-dynamodb ([#1230](#1230)) ([3aa25d0](3aa25d0)) * **deps:** bump dafny-lang/setup-dafny-action in /.github/workflows ([#1200](#1200)) ([5284f0b](5284f0b)) * **deps:** bump software.amazon.awssdk:bom ([#1227](#1227)) ([abd1727](abd1727)) * **deps:** bump software.amazon.awssdk:bom ([#1229](#1229)) ([bf3e1c3](bf3e1c3)) * **deps:** bump software.amazon.awssdk:core ([#1228](#1228)) ([9c67729](9c67729)) * do not add beacons when FORCE_PLAINTEXT_WRITE is used. ([#1232](#1232)) ([23c8a18](23c8a18)) * include bad item keys in query errors ([#1244](#1244)) ([07bba8b](07bba8b)) * update version to snapshot ([#1225](#1225)) ([c817b5b](c817b5b)) --------- Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>

## [3.6.1](v3.6.0...v3.6.1) (2024-08-12) ### Fixes * allow multi-tenant queries with allow_plaintext ([#1240](#1240)) ([1487d7e](1487d7e)) * **TestVectors:** define StartUpObject in csproj ([#1231](#1231)) ([2f97bf3](2f97bf3)) * update error message ([#1270](#1270)) ([7157e4d](7157e4d)) ### Maintenance * Add examples to examine contents of query error list ([#1251](#1251)) ([b5705ee](b5705ee)) * **CI:** add smithy diff checker GHA ([#1226](#1226)) ([86406f5](86406f5)) * **deps:** bump actions/setup-dotnet from 3 to 4 in /.github/workflows ([#1191](#1191)) ([c3b736e](c3b736e)) * **deps:** bump aws-actions/configure-aws-credentials ([#1190](#1190)) ([becbd0a](becbd0a)) * **deps:** bump com.amazonaws:aws-java-sdk-dynamodb ([#1230](#1230)) ([3aa25d0](3aa25d0)) * **deps:** bump dafny-lang/setup-dafny-action in /.github/workflows ([#1200](#1200)) ([5284f0b](5284f0b)) * **deps:** bump software.amazon.awssdk:bom ([#1227](#1227)) ([abd1727](abd1727)) * **deps:** bump software.amazon.awssdk:bom ([#1229](#1229)) ([bf3e1c3](bf3e1c3)) * **deps:** bump software.amazon.awssdk:core ([#1228](#1228)) ([9c67729](9c67729)) * do not add beacons when FORCE_PLAINTEXT_WRITE is used. ([#1232](#1232)) ([23c8a18](23c8a18)) * include bad item keys in query errors ([#1244](#1244)) ([07bba8b](07bba8b)) * **release:** 3.6.1 ([#1266](#1266)) ([64374e2](64374e2)), closes [#1240](#1240) [#1231](#1231) [#1251](#1251) [#1226](#1226) [#1191](#1191) [#1190](#1190) [#1230](#1230) [#1200](#1200) [#1227](#1227) [#1229](#1229) [#1228](#1228) [#1232](#1232) [#1244](#1244) [#1225](#1225) * update version to snapshot ([#1225](#1225)) ([c817b5b](c817b5b))

## [3.6.1](v3.6.0...v3.6.1) (2024-08-12) ### Fixes * allow multi-tenant queries with allow_plaintext ([#1240](#1240)) ([1487d7e](1487d7e)) * **TestVectors:** define StartUpObject in csproj ([#1231](#1231)) ([2f97bf3](2f97bf3)) * update error message ([#1270](#1270)) ([7157e4d](7157e4d)) ### Maintenance * Add examples to examine contents of query error list ([#1251](#1251)) ([b5705ee](b5705ee)) * **CI:** add smithy diff checker GHA ([#1226](#1226)) ([86406f5](86406f5)) * **deps:** bump actions/setup-dotnet from 3 to 4 in /.github/workflows ([#1191](#1191)) ([c3b736e](c3b736e)) * **deps:** bump aws-actions/configure-aws-credentials ([#1190](#1190)) ([becbd0a](becbd0a)) * **deps:** bump com.amazonaws:aws-java-sdk-dynamodb ([#1230](#1230)) ([3aa25d0](3aa25d0)) * **deps:** bump dafny-lang/setup-dafny-action in /.github/workflows ([#1200](#1200)) ([5284f0b](5284f0b)) * **deps:** bump software.amazon.awssdk:bom ([#1227](#1227)) ([abd1727](abd1727)) * **deps:** bump software.amazon.awssdk:bom ([#1229](#1229)) ([bf3e1c3](bf3e1c3)) * **deps:** bump software.amazon.awssdk:core ([#1228](#1228)) ([9c67729](9c67729)) * do not add beacons when FORCE_PLAINTEXT_WRITE is used. ([#1232](#1232)) ([23c8a18](23c8a18)) * include bad item keys in query errors ([#1244](#1244)) ([07bba8b](07bba8b)) * **release:** 3.6.1 ([#1266](#1266)) ([64374e2](64374e2)), closes [#1240](#1240) [#1231](#1231) [#1251](#1251) [#1226](#1226) [#1191](#1191) [#1190](#1190) [#1230](#1230) [#1200](#1200) [#1227](#1227) [#1229](#1229) [#1228](#1228) [#1232](#1232) [#1244](#1244) [#1225](#1225) * update version to snapshot ([#1225](#1225)) ([c817b5b](c817b5b)) * lint * remove recursive reference

chore: Add examples to examine contents of query error list

5a77786

ajewellamz requested a review from a team as a code owner August 6, 2024 23:37

ajewellamz added 2 commits August 6, 2024 20:48

java

e9f8409

m

2351d7d

robin-aws reviewed Aug 7, 2024

View reviewed changes

lucasmcdonald3 reviewed Aug 7, 2024

View reviewed changes

Comment thread ...DynamoDbEncryption/src/main/java/software/amazon/cryptography/examples/ScanErrorExample.java Outdated

Comment thread Examples/runtimes/net/src/ScanErrorExample.cs Outdated

ajewellamz added 3 commits August 7, 2024 14:23

feedback

a070375

m

084d23b

recursive

3052226

lucasmcdonald3 approved these changes Aug 7, 2024

View reviewed changes

ajewellamz merged commit b5705ee into main Aug 7, 2024

ajewellamz deleted the ajewell/query-error-examples branch August 7, 2024 23:25

seebees mentioned this pull request Aug 12, 2024

chore(release): 3.6.1 #1266

Merged

seebees mentioned this pull request Aug 14, 2024

chore(release): 3.6.1 - update #1271

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Add examples to examine contents of query error list#1251

chore: Add examples to examine contents of query error list#1251
ajewellamz merged 6 commits intomainfrom
ajewell/query-error-examples

ajewellamz commented Aug 6, 2024

Uh oh!

robin-aws left a comment

Uh oh!

Uh oh!

robin-aws Aug 7, 2024

Uh oh!

ajewellamz Aug 7, 2024

Uh oh!

robin-aws Aug 7, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lucasmcdonald3 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ajewellamz commented Aug 6, 2024

Uh oh!

robin-aws left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

robin-aws Aug 7, 2024

Choose a reason for hiding this comment

Uh oh!

ajewellamz Aug 7, 2024

Choose a reason for hiding this comment

Uh oh!

robin-aws Aug 7, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lucasmcdonald3 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants