Skip to content

chore(v2): e2e tests #1571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scottgerring merged 3 commits into from
Feb 28, 2024
Merged

chore(v2): e2e tests #1571

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3bc8cd4
Chore: fix e2e tests and build config
scottgerring Feb 22, 2024
5089d3f
Use the right aspect library
scottgerring Feb 22, 2024
7395399
Merge branch 'v2' into chore/fix-v2-e2e-tests
scottgerring Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/powertools-examples-idempotency/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
</aspectLibrary>
<aspectLibrary>
<groupId>software.amazon.lambda</groupId>
<artifactId>powertools-idempotency-dynamodb</artifactId>
Copy link
Copy Markdown
Contributor Author

@scottgerring scottgerring Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The aspect is in core, not DDB

<artifactId>powertools-idempotency-core</artifactId>
</aspectLibrary>
</aspectLibraries>
</configuration>
Expand Down
4 changes: 2 additions & 2 deletions powertools-e2e-tests/handlers/idempotency/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<dependencies>
<dependency>
<groupId>software.amazon.lambda</groupId>
<artifactId>powertools-idempotency</artifactId>
<artifactId>powertools-idempotency-dynamodb</artifactId>
Copy link
Copy Markdown
Contributor Author

@scottgerring scottgerring Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was breaking tests

</dependency>
<dependency>
<groupId>software.amazon.lambda</groupId>
Expand Down Expand Up @@ -43,7 +43,7 @@
<aspectLibraries>
<aspectLibrary>
<groupId>software.amazon.lambda</groupId>
<artifactId>powertools-idempotency</artifactId>
<artifactId>powertools-idempotency-core</artifactId>
Copy link
Copy Markdown
Contributor Author

@scottgerring scottgerring Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was breaking tests

</aspectLibrary>
<aspectLibrary>
<groupId>software.amazon.lambda</groupId>
Expand Down
2 changes: 1 addition & 1 deletion ...ts/handlers/idempotency/src/main/java/software/amazon/lambda/powertools/e2e/Function.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
import software.amazon.lambda.powertools.idempotency.Idempotency;
import software.amazon.lambda.powertools.idempotency.IdempotencyConfig;
import software.amazon.lambda.powertools.idempotency.Idempotent;
import software.amazon.lambda.powertools.idempotency.persistence.DynamoDBPersistenceStore;
import software.amazon.lambda.powertools.idempotency.persistence.dynamodb.DynamoDBPersistenceStore;
Copy link
Copy Markdown
Contributor Author

@scottgerring scottgerring Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was breaking tests

import software.amazon.lambda.powertools.logging.Logging;


Expand Down
4 changes: 2 additions & 2 deletions powertools-e2e-tests/handlers/largemessage_idempotent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<dependencies>
<dependency>
<groupId>software.amazon.lambda</groupId>
<artifactId>powertools-idempotency</artifactId>
<artifactId>powertools-idempotency-dynamodb</artifactId>
Copy link
Copy Markdown
Contributor Author

@scottgerring scottgerring Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was breaking tests

</dependency>
<dependency>
<groupId>software.amazon.lambda</groupId>
Expand Down Expand Up @@ -47,7 +47,7 @@
<aspectLibraries>
<aspectLibrary>
<groupId>software.amazon.lambda</groupId>
<artifactId>powertools-idempotency</artifactId>
<artifactId>powertools-idempotency-core</artifactId>
Copy link
Copy Markdown
Contributor Author

@scottgerring scottgerring Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The aspect is in core, not DDB

</aspectLibrary>
<aspectLibrary>
<groupId>software.amazon.lambda</groupId>
Expand Down
2 changes: 1 addition & 1 deletion ...largemessage_idempotent/src/main/java/software/amazon/lambda/powertools/e2e/Function.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
import software.amazon.lambda.powertools.idempotency.IdempotencyConfig;
import software.amazon.lambda.powertools.idempotency.IdempotencyKey;
import software.amazon.lambda.powertools.idempotency.Idempotent;
import software.amazon.lambda.powertools.idempotency.persistence.DynamoDBPersistenceStore;
import software.amazon.lambda.powertools.idempotency.persistence.dynamodb.DynamoDBPersistenceStore;
import software.amazon.lambda.powertools.largemessages.LargeMessage;
import software.amazon.lambda.powertools.logging.Logging;

Expand Down
8 changes: 5 additions & 3 deletions powertools-e2e-tests/handlers/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,7 @@
<module>logging</module>
<module>tracing</module>
<module>metrics</module>
<module>batch</module>
<module>idempotency</module>
<module>largemessage</module>
<module>largemessage_idempotent</module>
<module>parameters</module>
<module>validation-alb-event</module>
<module>validation-apigw-event</module>
Expand Down Expand Up @@ -75,6 +72,11 @@
<artifactId>powertools-idempotency</artifactId>
<version>${lambda.powertools.version}</version>
</dependency>
<dependency>
<groupId>software.amazon.lambda</groupId>
<artifactId>powertools-idempotency-dynamodb</artifactId>
<version>${lambda.powertools.version}</version>
</dependency>
<dependency>
<groupId>software.amazon.lambda</groupId>
<artifactId>powertools-parameters-appconfig</artifactId>
Expand Down