Sc/lti advantage#23
Merged
Merged
Conversation
seanrcollings
commented
Jul 30, 2024
Comment on lines
+38
to
+48
| def index | ||
| page, meta = filter( | ||
| AtomicTenant::LtiDeployment.where(application_instance_id:), | ||
| search_col: "deployment_id", | ||
| ) | ||
|
|
||
| render json: { | ||
| deployments: page, | ||
| meta: | ||
| } | ||
| end |
Contributor
Author
There was a problem hiding this comment.
@blunckr-aj I think you touched some of the LTI deployment code recently & the search method above this is more complicated than I made this. What's the reasoning for the additional complexity?
Contributor
There was a problem hiding this comment.
We discussed in slack, but the original version pulls in info from atomic_tenant that we don't think really needs to be here
blunckr-aj
reviewed
Jul 30, 2024
| include Filtering | ||
|
|
||
| def search | ||
| def search |
Contributor
There was a problem hiding this comment.
maybe we could add a comment that this one is deprecated/only used by the old admin app. same with the other controllers
Comment on lines
+38
to
+48
| def index | ||
| page, meta = filter( | ||
| AtomicTenant::LtiDeployment.where(application_instance_id:), | ||
| search_col: "deployment_id", | ||
| ) | ||
|
|
||
| render json: { | ||
| deployments: page, | ||
| meta: | ||
| } | ||
| end |
Contributor
There was a problem hiding this comment.
We discussed in slack, but the original version pulls in info from atomic_tenant that we don't think really needs to be here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.